From: Kirk Lund
Sent: Friday, May 28, 2021 3:19 PM
To: dev@geode.apache.org
Subject: Re: Cleaning up the codebase - use curly braces everywhere
+1 Also, I think if the entire work is done by IntelliJ then just mention
that in the PR description and I'm happy to add approval without steppi
der wrote:
> +1 thanks for working on this
>
> From: Donal Evans
> Sent: Thursday, May 27, 2021 10:22 AM
> To: dev@geode.apache.org
> Subject: Cleaning up the codebase - use curly braces everywhere
>
> Hi Geode dev,
>
> I've
+1 thanks for working on this
From: Donal Evans
Sent: Thursday, May 27, 2021 10:22 AM
To: dev@geode.apache.org
Subject: Cleaning up the codebase - use curly braces everywhere
Hi Geode dev,
I've recently been looking at ways to improve code quality in small
: Friday, May 28, 2021 at 6:36 AM
To: dev@geode.apache.org
Subject: Re: Cleaning up the codebase - use curly braces everywhere
Regarding doing the changes at package level, there would still be a huge
amount to review for certain code owners, and some code owners would get tagged
to review multiple of
Anilkumar Gingade
Sent: Thursday, May 27, 2021 1:20 PM
To: dev@geode.apache.org
Subject: Re: Cleaning up the codebase - use curly braces everywhere
+1
Instead of big merge; can this be done at package level; just a thought.
-Anil.
On 5/27/21, 10:51 AM, "Dale Emery" wrote:
We might
ing to spot violations immediately as they’re introduced.
A disadvantage is that this somewhat couples Geode to a particular IDE.
Dale
From: Donal Evans
Date: Thursday, May 27, 2021 at 10:22 AM
To: dev@geode.apache.org
Subject: Cleaning up the codebase - use curly braces e
: Cleaning up the codebase - use curly braces everywhere
Hi Geode dev,
I've recently been looking at ways to improve code quality in small ways
throughout the codebase, and as a starting point, I thought it would be good to
make it so that we're consistently using curly braces for co
+1. Also really like Naba's idea of incorporating this into spotless.
On May 27, 2021, at 10:46 AM, Raymond Ingles
mailto:ring...@vmware.com>> wrote:
+1 Sounds like a good idea. Since always using curly braces is part of the
style guide, fixing this makes sense.
The only possible additional st
+1 Sounds like a good idea. Since always using curly braces is part of the
style guide, fixing this makes sense.
The only possible additional step for
large-but-automatically-generated-and-specifically-targeted PRs like this is
running the test suite with code coverage, making sure the updated
Evans
Sent: Thursday, May 27, 2021 10:22:21 AM
To: dev@geode.apache.org
Subject: Cleaning up the codebase - use curly braces everywhere
Hi Geode dev,
I've recently been looking at ways to improve code quality in small ways
throughout the codebase, and as a starting point, I thought it wo
This is great! Thank you for doing this, Donal!
Thanks you!! I believe these targeted whole source tree changes like this are
great. As long as it isn’t a mix of hand rolled and automated changes I think a
reviewer can trust that the if heart of the change is correct there is no
reason to review all 3000 lines changed. I think it gets harder
Hi Geode dev,
I've recently been looking at ways to improve code quality in small ways
throughout the codebase, and as a starting point, I thought it would be good to
make it so that we're consistently using curly braces for control flow
statements everywhere, since this is something that's spe
13 matches
Mail list logo
