Re: FunctionService Proposal

+1 Udo. A very clear and descriptive spec; Nice work! In short, these would be welcomed changes and would have very little impact to *Spring Data for Apache Geode*, which nicely abstracts this API even further using its POJO-based, Annotation configuration model for Function Implementations as

Re: FunctionService Proposal

+1 for making the function service not static, and splitting servers from clients. Also +1 for Dan's suggestion. On Wed, Mar 7, 2018 at 2:51 PM, Patrick Rhomberg wrote: > I did not know that! And then, yes, onRegion is much better. > > On Wed, Mar 7, 2018 at 2:43 PM, Dan

Re: FunctionService Proposal

I did not know that! And then, yes, onRegion is much better. On Wed, Mar 7, 2018 at 2:43 PM, Dan Smith wrote: > > If we're not opposed to descriptive verbosity, I might prefer > "onServersHostingRegion" more than "onRegion". > > onRegion does not really mean "on the servers

Re: FunctionService Proposal

> If we're not opposed to descriptive verbosity, I might prefer "onServersHostingRegion" more than "onRegion". onRegion does not really mean "on the servers hosting region XXX". It only executes on a subset of the servers, potentially with retries, until it has covered that entire dataset once.

Re: FunctionService Proposal

+1 for iteration towards better single responsibility design and more easily-digestible classes. Regarding method names, I think that there would be some good utility in having "onGroup" methods, as well. If we're not opposed to descriptive verbosity, I might prefer "onServersHostingRegion" more

Re: FunctionService Proposal

I agree with Dan here. The C++ client took a stab at making ExecutionService less static but didn't go this far. Rather than pull Cache out of the either it is passed into each of the static factory methods, wither as a Region, Pool or Cache itself. I like propose to add Cache::getFunctionService

FunctionService Proposal

Hi there Apache Dev's, Please look at the proposal to improve the FunctionService and remove the static invocation of it from within the Cache.