Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

> > Manually post the artifacts and correct the gradle for 1.9 Do we have a guide somewhere for how to manually add files to a released version? I might be able to wing it, but this is something where I'd rather be 100% certain. On Fri, Dec 21, 2018 at 4:33 PM Patrick Rhomberg wrote: > I have a

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

I have a preliminary "clean up how we configure publication" PR open which *does not* address these issues. However, if anyone picks up a ticket for these issues while I'm away, I would appreciate it stemming from that work (a) to be clean and modular, and (b) to not heap merge conflicts on existi

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Yep. Sure does look like all the things you mentioned are true. The 'artifacts' configuration is a hold-over from the Legacy (a.k.a. Gradle 1.0) publishing, which I believe the Nexus plugin mimicked / used in its configuration. It looks like both the geode-pulse WAR not publishing and the source

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

See also https://issues.apache.org/jira/browse/GEODE-6208 about publishing the pulse war. Anthony > On Dec 21, 2018, at 2:06 PM, Anthony Baker wrote: > > The 1.7.0 version of publish.gradle had stuff like: > > extraArchive { > sources =

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

The 1.7.0 version of publish.gradle had stuff like: extraArchive { sources = true javadoc = true tests = false } and afterEvaluate { // uses the tasks created by nexus for sources and javadoc if (!getTasksByName('sourcesJar', false).isEmpty()) {

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

If the only thing that is missing is that we didn’t publish jars then we just need to publish the jars. We don’t need to change the build to do it and rebuild. Manually post the artifacts and correct the gradle for 1.9. > On Dec 21, 2018, at 1:07 PM, Owen Nichols wrote: > > Maybe I misundersta

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Maybe I misunderstand what happened. It sounded like the problem was essentially just “forgot to upload some docs”. If it’s more than that, then in addition to 1.8.1 do we need to take any steps to retract 1.8.0 as DOA? > On Dec 21, 2018, at 12:59 PM, Alexander Murmann wrote: > > Owen, chan

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Owen, changing what's in a particular version of a library after it has been shipped to me breaks the contract established by the version number, regardless of how minor the changes are. On Fri, Dec 21, 2018 at 12:04 PM Owen Nichols wrote: > My feeling is that a 1.8.1 is not the right response.

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

My feeling is that a 1.8.1 is not the right response. If we can put the missing jars in place manually for 1.8.0 that should be sufficient. -Owen > On Dec 21, 2018, at 9:16 AM, Alexander Murmann wrote: > > I confirmed what we upload to the Nexus staging site again with both 1.7 > and 1.8. I t

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

I confirmed what we upload to the Nexus staging site again with both 1.7 and 1.8. I think we must have stopped uploading these files when we switched to the maven-publish plugin as part of GEODE-5597. Can someone who worked on the recent build changes please take a look? I created GEODE-6235 to tr

Re: Geode 1.8.0 maven repository is missing sources and javadoc jars

Thank you for catching this Brian! I will take a look and see how we can address this. On Thu, Dec 20, 2018 at 3:21 PM Brian Rowe wrote: > The maven repository for 1.8.0 seems to be missing the 1.8.0 source jars. > This means people using an IDE can't download these jars automatically to > see t

Geode 1.8.0 maven repository is missing sources and javadoc jars

The maven repository for 1.8.0 seems to be missing the 1.8.0 source jars. This means people using an IDE can't download these jars automatically to see the geode source in their IDE. Specifically, we see the following in 1.8 vs 1.7: https://repo.maven.apache.org/maven2/org/apache/geode/geode-core/