+1 for #2
On Mon, Oct 9, 2017 at 12:35 PM, Kirk Lund wrote:
> Sounds good.
>
> Right now the User API for Statistics is in org.apache.geode (where it's
> been since before my time) but we could deprecate it there and move it to
> org.apache.geode.statistics.
>
> On Mon, Oct 9, 2017 at 12:28 PM,
Sounds good.
Right now the User API for Statistics is in org.apache.geode (where it's
been since before my time) but we could deprecate it there and move it to
org.apache.geode.statistics.
On Mon, Oct 9, 2017 at 12:28 PM, Udo Kohlmeyer
wrote:
> @Kirk, I believe that internal Geode moduels can b
@Kirk, I believe that internal Geode moduels can be handled with approach
#2, e.g "org.apache.geode.logging.internal"...
I believe that we should think modules with public interfaces... even if
the only consumers of those interfaces is another Geode module. How else
would we achieve complete modul
>> Do we want to start creating non-internal packages for things like
logging
>> even if there are no classes in the non-internal package?
I think that should be fine...It shows that module doesn't have any
external APIs.
+1 for approach 2.
-Anil.
On Mon, Oct 9, 2017 at 11:50 AM, Kirk Lund wr
The real reason we have both is because we have some internal components
that don't have any corresponding User API (currently).
For example, we have org.apache.geode.internal.logging and
org.apache.geode.internal.statistics but neither of these have a
non-internal package.
Do we want to start cr
+1 for #2
We will need to be careful refactoring existing code if classes are sent
over the wire.
-Dan
On Mon, Oct 9, 2017 at 10:36 AM, Udo Kohlmeyer wrote:
> Hi there Geode devs,
>
> Whilst going through the code base I found that we have 2 differing
> approaches of how we classify (or packag
Hi there Geode devs,
Whilst going through the code base I found that we have 2 differing
approaches of how we classify (or package structures) internal code.
The first is /org.apache.geode.*INTERNAL*.module/ the other is
/org.apache.geode.module.*INTERNAL*/.
Can anyone explain the differenc
