Re: Old geode-benchmark PRs

2020-01-23 Thread Jacob Barrett
at least he/she will find >> the tickets in Jira. >> >> >> >> De: Donal Evans >> Enviado: jueves, 23 de enero de 2020 16:45 >> Para: dev@geode.apache.org >> Asunto: Re: Old geode-benchmark PRs >> >> @Alexander, I haven

Re: Old geode-benchmark PRs

2020-01-23 Thread Robert Houghton
o de 2020 16:45 > Para: dev@geode.apache.org > Asunto: Re: Old geode-benchmark PRs > > @Alexander, I haven't looked at them in months and they never received any > formal review on GitHub, so it's hard to know for sure if they're ready to > merge or not, but as Jake said, they p

RE: Old geode-benchmark PRs

2020-01-23 Thread Alberto Bustamante Reyes
Para: dev@geode.apache.org Asunto: Re: Old geode-benchmark PRs @Alexander, I haven't looked at them in months and they never received any formal review on GitHub, so it's hard to know for sure if they're ready to merge or not, but as Jake said, they probably need some massaging to g

Re: Old geode-benchmark PRs

2020-01-23 Thread Donal Evans
@Alexander, I haven't looked at them in months and they never received any formal review on GitHub, so it's hard to know for sure if they're ready to merge or not, but as Jake said, they probably need some massaging to get the resource usage just right and minimize variance. If at this point there'

Re: Old geode-benchmark PRs

2020-01-23 Thread Alexander Murmann
Donal, are you still looking at these? If they aren't ready to merge and not being worked on, should they be closed? On Wed, Jan 22, 2020 at 3:32 PM Donal Evans wrote: > Two of those PRs are mine, so perhaps I can give a bit of context for > people who might look at them. The oldest of the two,

Re: Old geode-benchmark PRs

2020-01-22 Thread Jacob Barrett
I hate to just close what’s there but it also likely needs some massaging. Additions to the benchmarks risk destabilizing the CI if the benchmark has a wide variance. I don’t have time right now to spend on tuning new benchmarks. If someone else does please step up and take it on. > On Jan 22,

Re: Old geode-benchmark PRs

2020-01-22 Thread Donal Evans
Two of those PRs are mine, so perhaps I can give a bit of context for people who might look at them. The oldest of the two, "Feature/Add PdxType benchmark and additional framework flexibility" was an attempt to quantify and maintain the improvement in performance for PdxType creation when large num

Old geode-benchmark PRs

2020-01-22 Thread Dan Smith
Hi, I noticed we have some old outstanding PRs for the geode-benchmarks project. Are any of these things we want to merge or should we close them out? https://github.com/apache/geode-benchmarks/pulls -Dan