Re: PR Checks issues?

2019-12-13 Thread Robert Houghton
We could have the content of the PR jobs check that actual sources changed, before doing any real 'work' or 'validation' of the change. If the patch is only CI or readme (not docs, those get compiled) then we can exit with a clean state. Saves time, and money! If the issue is the lack of

Re: PR Checks issues?

2019-12-13 Thread Owen Nichols
Hi Michael, that does sound like a frustrating experience. Thanks for saying something — it is harder to track how often this is occurring if people don’t report the issue on the dev list. Geode’s PR pipeline uses https://hub.docker.com/r/teliaoss/github-pr-resource

Re: PR Checks issues?

2019-12-13 Thread Michael Oleske
Well lack of review was one part. The major part was that if you click on the checks from the other empty commits, you'll see that the required passing jobs never triggered (only the LGTM checks). -michael On Fri, Dec 13, 2019 at 11:43 AM Joey McAllister wrote: > Hi Michael, > > That may have

Re: PR Checks issues?

2019-12-13 Thread Joey McAllister
Hi Michael, That may have been connected, at least in part, to a lack of a review. I have given my review on adding this info to the README, which I think looks good, and things seem to have gone green. That said, as I mentioned in my review, I also wouldn't mind seeing a thumbs up (or other

PR Checks issues?

2019-12-13 Thread Michael Oleske
Hi Geode Dev! This PR https://github.com/apache/geode/pull/4406 is a change to the readme. However it took 3 empty commits to get it to go green enough to be allowed to be merged. This seems odd, especially with just a readme change. Is there something going with how CI works for PRs? This