Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-27 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55781/#review163295 --- Ship it! Ship It! - Jared Stewart On Jan. 26, 2017, 12:35 a.

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-26 Thread Jared Stewart
> On Jan. 26, 2017, 10:01 p.m., Jared Stewart wrote: > > Can you help me understand what the introspectAndConvert method is trying > > to do? Its use of generics seems very strange to me and it has many > > unchecked casts which could fail at runtime. > > Kevin Duling wrote: > The idea beh

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-26 Thread Kevin Duling
> On Jan. 26, 2017, 2:01 p.m., Jared Stewart wrote: > > Can you help me understand what the introspectAndConvert method is trying > > to do? Its use of generics seems very strange to me and it has many > > unchecked casts which could fail at runtime. > > Kevin Duling wrote: > The idea behi

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-26 Thread Jared Stewart
> On Jan. 26, 2017, 10:01 p.m., Jared Stewart wrote: > > Can you help me understand what the introspectAndConvert method is trying > > to do? Its use of generics seems very strange to me and it has many > > unchecked casts which could fail at runtime. > > Kevin Duling wrote: > The idea beh

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-26 Thread Kevin Duling
> On Jan. 26, 2017, 2:01 p.m., Jared Stewart wrote: > > Can you help me understand what the introspectAndConvert method is trying > > to do? Its use of generics seems very strange to me and it has many > > unchecked casts which could fail at runtime. The idea behind it is to convert a String i

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-26 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55781/#review163180 --- Can you help me understand what the introspectAndConvert method is

Re: Review Request 55781: GEODE-2298: Executing a Function via Swagger without parameters throws an exception

2017-01-25 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55781/ --- (Updated Jan. 25, 2017, 4:35 p.m.) Review request for geode, Jinmei Liao, Jared