Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-27 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/#review163300 --- Ship it! Ship It! - Jared Stewart On Jan. 27, 2017, 5:26 p.m

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-27 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/#review163294 --- Ship it! Ship It! - Kirk Lund On Jan. 27, 2017, 5:26 p.m., K

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-27 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/ --- (Updated Jan. 27, 2017, 9:26 a.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-27 Thread Kevin Duling
> On Jan. 26, 2017, 4:11 p.m., Kirk Lund wrote: > > geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseControllerJUnitTest.java, > > line 58 > > > > > > You're missing fail("messag

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-26 Thread Kevin Duling
> On Jan. 26, 2017, 4:11 p.m., Kirk Lund wrote: > > geode-web-api/src/test/java/org/apache/geode/rest/internal/web/controllers/AbstractBaseControllerJUnitTest.java, > > line 58 > > > > > > You're missing fail("messag

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/#review163205 --- geode-web-api/src/test/java/org/apache/geode/rest/internal/web/co

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-26 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/ --- (Updated Jan. 26, 2017, 3:30 p.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-26 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/#review163149 --- This is the perfect opportunity to introduce AbstractBaseControlle

Review Request 55988: GEODE-2294: When attempting to execute a function via Dev Rest API, error messages are being lost

2017-01-26 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55988/ --- Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund. Bugs: GEOD