Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-07 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/ --- (Updated March 7, 2017, 6:24 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/ --- (Updated March 3, 2017, 12:03 a.m.) Review request for geode, Jared Stewart,

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/ --- (Updated March 3, 2017, 12:01 a.m.) Review request for geode, Jared Stewart,

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jared Stewart
> On March 2, 2017, 6:44 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > > Lines 154 (patched) > > > > > > I don't think that we ought to manually

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jinmei Liao
> On March 2, 2017, 6:44 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > > Lines 154 (patched) > > > > > > I don't think that we ought to manually

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Kirk Lund
> On March 2, 2017, 6:39 p.m., Kirk Lund wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java > > Lines 67 (patched) > > > > > > Wouldn't it be better to just Chain

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/#review167712 ---

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/#review167694 ---

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Jinmei Liao
> On March 2, 2017, 6:31 p.m., Ken Howe wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > > Line 140 (original), 114 (patched) > > > > > > Why is arg changed from

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/#review167703 ---

Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir

2017-03-02 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57242/#review167696 --- Ship it! Ship It! - Kevin Duling On March 2, 2017, 7:30