Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169096 --- Ship it! Ship It! - Jinmei Liao On March 15, 2017, 8:02 p.m.

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169085 --- Ship it! Ship It! - Kevin Duling On March 15, 2017, 1:02 p.m

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169064 --- Ship it! Ship It! - Jared Stewart On March 15, 2017, 8:02 p.

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review169054 --- Ship it! Ship It! - Ken Howe On March 15, 2017, 8:02 p.m., K

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Kirk Lund
> On March 14, 2017, 10:13 p.m., Ken Howe wrote: > > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java > > Lines 395-396 (original), 399-401 (patched) > > > > > > Is the

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-15 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/ --- (Updated March 15, 2017, 8:02 p.m.) Review request for geode, Jinmei Liao, Jare

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-14 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review168945 --- Fix it, then Ship it! geode-core/src/test/java/org/apache/geod

Re: Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-14 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review168911 --- It looks to me like `DIR_OF_DELETED_FILES_IS_ONE_FILE` is unused.

Review Request 57573: GEODE-2648: always move deleted files to dirOfDeletedFiles

2017-03-13 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/ --- Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, an