Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-21 Thread nabarun nag
> On April 21, 2017, 6:21 a.m., xiaojian zhou wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRegionListener.java > > Lines 104 (patched) > > > > > > Why you did not specify "this.r

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-21 Thread nabarun nag
> On April 21, 2017, 6:21 a.m., xiaojian zhou wrote: > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java > > Line 57 (original), 58 (patched) > > > > > > Acc

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58550/#review172584 --- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58550/#review172513 --- I think the main thrust of this change looks good - get the AEQ cr

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-19 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58550/ --- (Updated April 20, 2017, 2:03 a.m.) Review request for geode, Jason Huynh and D