Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-31 Thread Jinmei Liao
> On May 31, 2017, 5:58 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > > Lines 96 (patched) > > > > > > should we put this in the MemberStarterRule so

Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-31 Thread Jared Stewart
> On May 31, 2017, 5:58 p.m., Jinmei Liao wrote: > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java > > Lines 96 (patched) > > > > > > should we put this in the MemberStarterRule so

Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-31 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59611/#review176484 --- geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server

Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-30 Thread Jared Stewart
> On May 30, 2017, 11:33 p.m., Ken Howe wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ClasspathScanLoadHelper.java > > Line 63 (original), 41 (patched) > > > > > > This new method i

Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-30 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59611/#review176383 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Re: Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-26 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59611/ --- (Updated May 26, 2017, 10:02 p.m.) Review request for geode, Emily Yeh, Jinmei

Review Request 59611: GEODE-2989: Improve mechanism for scanning the classpath to find gfsh commands

2017-05-26 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59611/ --- Review request for geode. Repository: geode Description --- GEODE-2989: