Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-24 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review181245 --- Ship it! +1! - Emily Yeh On July 17, 2017, 3:49 p.m.,

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180740 --- Ship it! +1 - Kirk Lund On July 17, 2017, 3:49 p.m., Jinmei

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-17 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180683 --- Ship it! Ship It! - Ken Howe On July 17, 2017, 3:49 p.m.,

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-17 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/ --- (Updated July 17, 2017, 3:49 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-10 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review180088 ---

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-06 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179794 --- One small change that might be helpful is to note the version -

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-06 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179793 --- Ship it! Ship It! - Jared Stewart On July 6, 2017, 4:03

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-06 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/ --- (Updated July 6, 2017, 4:03 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-06 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179785 --- For the record, and as discussed offline, I think 1-arg method

Review Request 60666: geode-3166: remove the uncalled getCredential method

2017-07-05 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and