Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

> On July 13, 2017, 1:40 a.m., Galen O'Sullivan wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java > > Lines 38 (patched) > > > > > > I had

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180369 --- Tests could use a little thoughtful addition of whitespace.

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180371 --- Ship it! Ship It! - Udo Kohlmeyer On July 12, 2017, 6:27

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180365 --- Ship it! Ship It! - Bruce Schuchardt On July 12, 2017,

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

> On July 12, 2017, 8:07 p.m., Bruce Schuchardt wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java > > Lines 55 (patched) > > > > > > I think we

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

> On July 11, 2017, 5:17 p.m., Bruce Schuchardt wrote: > > geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java > > Lines 138 (patched) > > > > > > need

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180353 --- Ship it! Ship It! - Alexander Murmann On July 12, 2017,

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180349 ---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

We will still return ErrorResponses for any failures or invalid messages, we've just removed the serverInternal and retriable fields from this message in favor a errorCode integer. On Wed, Jul 12, 2017 at 11:45 AM, Michael Stolz wrote: > We removed error feedback? > So how is

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

We removed error feedback? So how is an application programmer supposed to determine what failed now? Without that information we may have rendered putAll unusable for some cases. -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: +1-631-835-4771 On Wed, Jul 12, 2017 at 1:45 PM,

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/ --- (Updated July 12, 2017, 6:01 p.m.) Review request for geode, Alexander

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/ --- (Updated July 12, 2017, 6:27 p.m.) Review request for geode, Alexander

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/ --- (Updated July 12, 2017, 6:23 p.m.) Review request for geode, Alexander

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java > > Lines 81 (patched) > > > > > > I'm sure that

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review180212 ---

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

> On July 7, 2017, 11:51 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java > > Lines 48-50 (patched) > > > > > > I don't

Re: Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/#review179967 ---

Review Request 60718: GEODE-2997: New flow getAll/putAll

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60718/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen