Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183875 --- Ship it! Ship It! - Kirk Lund On Aug. 24, 2017, 10:02 p.m.,

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-24 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 24, 2017, 10:02 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-23 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 23, 2017, 8:43 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-23 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183621 --- geode-core/src/main/java/org/apache/geode/distributed/LocatorLaun

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 22, 2017, 9:28 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- (Updated Aug. 22, 2017, 6:26 p.m.) Review request for geode, Emily Yeh, Jinmei

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Jared Stewart
> On Aug. 17, 2017, 5:35 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > > Lines 2017 (patched) > > > > > > I think this double-ternary might be easier to

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-22 Thread Ken Howe
> On Aug. 17, 2017, 5:35 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > > Lines 2017 (patched) > > > > > > I think this double-ternary might be easier to

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-17 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183168 --- Ship it! Ship It! - Kirk Lund On Aug. 16, 2017, 9:21 p.m., K

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-17 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/#review183145 --- geode-core/src/main/java/org/apache/geode/distributed/LocatorLaun

Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

2017-08-16 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61701/ --- Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and