Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184391 --- Ship it! Ship It! - Hitesh Khamesra On Aug. 30, 2017, 8:48 p

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184389 --- Ship it! Ship It! - Alexander Murmann On Aug. 30, 2017, 8:48

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184385 --- Fix it, then Ship it! Looks good! Except for the one comparison

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-09-01 Thread Bruce Schuchardt
> On Aug. 29, 2017, 3:48 p.m., Alexander Murmann wrote: > > geode-protobuf/src/test/java/org/apache/geode/protocol/AuthenticationIntegrationTest.java > > Lines 105 (patched) > > > > > > We are doing this for the Roun

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-08-30 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- (Updated Aug. 30, 2017, 1:48 p.m.) Review request for geode, Alexander Murmann,

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-08-29 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- (Updated Aug. 29, 2017, 3:52 p.m.) Review request for geode, Alexander Murmann,

Re: Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-08-29 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/#review184098 --- The refactor is awesome! It would be nice though to have a test t

Review Request 61978: GEODE-3059: LoadMonitor.connectionClosed incrementing statistics only for client-server connection

2017-08-29 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61978/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,