Re: Update of SSLParameterExtension interface

2020-05-14 Thread Robert Houghton
There is an opportunity to take @Jacob Barrett s advice on using a real configuration class instead of an opaque 'Properties' class here. See https://github.com/apache/geode/pull/5115, where we test the API breaking change with an exemption file. On Thu, May 7, 2020 at 8:52 AM Jacob Barrett wrote

Re: Update of SSLParameterExtension interface

2020-05-07 Thread Jacob Barrett
I have some concerns with using Properties in public APIs. The use of Properties is not strongly typed. I can’ tell from one property to the next what the type is. I can’t get compile time errors is the type is wrong. I don’t know what goes into a Property based on the interface or any magic and

Re: Update of SSLParameterExtension interface

2020-05-04 Thread Bruce Schuchardt
I guess that would have to go into the 1.13 branch as well. This changes the public API but I think we should do it. The current API isn't usable since it refers to a non-public interface. On 5/4/20, 9:31 AM, "Mario Ivanac" wrote: Hi all, after comments that SSLParameterExtensi

Update of SSLParameterExtension interface

2020-05-04 Thread Mario Ivanac
Hi all, after comments that SSLParameterExtension interface has an init() method that takes a DistributionConfig as an argument (which is internal class), new solution is proposed to replace DistributionConfig with Properties. New PR is created with new proposal https://github.com/apache/geode/