[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #28 was SUCCESSFUL (with 1000 tests)

2015-08-07 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #28 was successful. --- Scheduled 1004 tests in total. https://build.spring.io/browse/SGF-NAG-28/ -- This me

Review Request 37239: GEODE-77: Enable multicast messaging, remove multicast discovery

2015-08-07 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37239/ --- Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianx

Re: Review Request 37209: GEODE-17 : Integrated Security Code Merge

2015-08-07 Thread Jacob Barrett
Performance vs. security should never be considered. Security trumps everything. We should adopt standards where available. We should use other open source libraries where applicable. As part of the Apache ecosystem now we need to look at Apache projects that may provide these capabilities. We

Re: Review Request 37209: GEODE-17 : Integrated Security Code Merge

2015-08-07 Thread Anthony Baker
Am I missing something? Not verifying the integrity of a security token creates a vulnerability, right? Have you quantified the performance impact of Spring Security? Anthony > > Agreed. Initially I had spec'd it out based on Spring Security. But Neelkanth > felt token based approach is bett

Re: Review Request 37209: GEODE-17 : Integrated Security Code Merge

2015-08-07 Thread Tushar Khairnar
> On Aug. 7, 2015, 3:48 p.m., Jens Deppe wrote: > > I'm not sure if this comment should go here or elsewhere as it is more > > about the overall approach and not the actual code. > > > > Specifically with regard to securing the REST endpoint(s). My feeling is > > that we are being way too pres

Re: Review Request 37209: GEODE-17 : Integrated Security Code Merge

2015-08-07 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37209/#review94552 --- I'm not sure if this comment should go here or elsewhere as it is mo

Re: Review Request 37209: GEODE-17 : Integrated Security Code Merge

2015-08-07 Thread Tushar Khairnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37209/ --- (Updated Aug. 7, 2015, 3:35 p.m.) Review request for geode, Amogh Shetkar and J

Re: Review Request 37209: GEODE-77 : Integrated Security Code Merge

2015-08-07 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37209/#review94548 --- I think this is meant to be for GEODE-17 - Jens Deppe On Aug. 7,

Review Request 37209: GEODE-77 : Integrated Security Code Merge

2015-08-07 Thread Tushar Khairnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37209/ --- Review request for geode and Amogh Shetkar. Repository: geode Description ---