[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #180 has FAILED

2016-01-04 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #180 failed. --- Scheduled No failed tests found, a possible compilation error. https://build.spring.io/browse/SG

Re: Revert three of my commits from today

2016-01-04 Thread Dan Smith
That looks fine to me. -Dan On Mon, Jan 4, 2016 at 4:41 PM, Kirk Lund wrote: > *I pushed three commits that are now causing problems with the > distributedTest task. I want to revert these so I have more time to figure > out what's wrong. (They were originally part of feature/GEODE-217 and I've

Revert three of my commits from today

2016-01-04 Thread Kirk Lund
*I pushed three commits that are now causing problems with the distributedTest task. I want to revert these so I have more time to figure out what's wrong. (They were originally part of feature/GEODE-217 and I've been trying to commit the changes from that branch to develop in much smaller pieces).

Re: Source distribution

2016-01-04 Thread Nitin Lamba
You're right Anthony - my bad. I did download the archive but accidentally opened the older tar.gz from April, 2015: geode-1.0.0.0-SNAPSHOT.src.tar.gz (the original source contributed to Apache). All's good now. Yes, did notice few extra folders but fixing that may be low priority. - Nitin _

Re: Source distribution

2016-01-04 Thread Anthony Baker
I wonder if we’re looking at different things?? When I download the night-build tarball at [1], I only found one Pivotal copyright: Anthony-Baker-MacBook-Pro:tmp abaker$ tar xf ~/Downloads/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar && grep -r Pivotal apache-geode-src-1.0.0-incubating-SNAPS

Re: Source distribution

2016-01-04 Thread Bruce Schuchardt
The gemfire-jgroups project has been deleted on the develop branch. That happened when feature/GEODE-77 was merged to develop. If it's still sitting around in a checkout it should be deleted. Le 1/4/2016 1:00 PM, Nitin Lamba a écrit : I didn't build locally but picked the artifacts that are g

Re: Source distribution

2016-01-04 Thread Nitin Lamba
I didn't build locally but picked the artifacts that are getting posted from CI: https://builds.apache.org/job/Geode-nightly/lastSuccessfulBuild/artifact/gemfire-assembly/build/distributions/apache-geode-src-1.0.0-incubating-SNAPSHOT.tar.gz All the java files I checked still had Pivotal copyright

Re: Source distribution

2016-01-04 Thread Anthony Baker
Hmmm, that sounds odd. The srcDistTar task uses the current working copy. You might try a `git clean -fd` to remove all non-version controlled artifacts (be careful!). Which copyrights are missing? Here’s what I see in the src distribution: Anthony-Baker-MacBook-Pro:distributions abaker$ hea

Re: Source distribution

2016-01-04 Thread Nitin Lamba
Thanks Anthony!! This is great progress as the community marches towards the first GEODE release! Besides the missing LICENSE and NOTICE files (you have a separate thread on GEODE-610), I noticed a few things in the src artifact: - The copyright updates are missing - It still has jgroups/ LGPL f

Re: LICENSE and NOTICE

2016-01-04 Thread Anthony Baker
Oops! Thanks for catching the typo. Anthony > On Jan 4, 2016, at 10:43 AM, Nitin Lamba wrote: > > I think Anthony meant 'feature/GEODE-610' branch: > https://github.com/apache/incubator-geode/tree/feature/GEODE-610 > > - Nitin > > > From: Michael Sto

Re: LICENSE and NOTICE

2016-01-04 Thread Nitin Lamba
I think Anthony meant 'feature/GEODE-610' branch: https://github.com/apache/incubator-geode/tree/feature/GEODE-610 - Nitin From: Michael Stolz Sent: Monday, January 4, 2016 9:55 AM To: dev@geode.incubator.apache.org Subject: Re: LICENSE and NOTICE I don'

Re: LICENSE and NOTICE

2016-01-04 Thread Michael Stolz
I don't see a GEODE-210 branch. Am I missing something? -- Mike Stolz Principal Engineer, GemFire Product Manager Mobile: 631-835-4771 On Mon, Jan 4, 2016 at 11:19 AM, Anthony Baker wrote: > Look on the feature/GEODE-210 branch. > > The source distribution versions are in the root directory. >

Re: [GitHub] incubator-geode pull request: Enabling direct reporting on Geode's...

2016-01-04 Thread Kirk Lund
+1 On Mon, Jan 4, 2016 at 9:04 AM, Mark Bretl wrote: > +1 > > --Mark > > On Fri, Jan 1, 2016 at 5:49 AM, Anthony Baker wrote: > > > +1 > > > > > On Dec 30, 2015, at 9:10 PM, Roman Shaposhnik > > wrote: > > > > > > On Mon, Dec 28, 2015 at 7:23 PM, William Markito > > wrote: > > >> +1 > > > >

Re: Review Request 41750: Modify all tests to use JUnit Categories

2016-01-04 Thread Kirk Lund
I forgot to checkout develop and pull it before using the feature finish cmd. It's merged in now! Thanks, Kirk On Monday, January 4, 2016, Jens Deppe wrote: > Kirk, > > Did your 'origin' remote change at all? Does 'git branch -v -v' tell you > anything interesting? > > --Jens > > On Mon, Jan 4

Re: Review Request 41750: Modify all tests to use JUnit Categories

2016-01-04 Thread Jens Deppe
Kirk, Did your 'origin' remote change at all? Does 'git branch -v -v' tell you anything interesting? --Jens On Mon, Jan 4, 2016 at 8:33 AM, Kirk Lund wrote: > Right now I'm stuck as git won't let me merge the changes to develop. I'm > not sure what to do next and I'm not going to experiment as

Re: [GitHub] incubator-geode pull request: Enabling direct reporting on Geode's...

2016-01-04 Thread Mark Bretl
+1 --Mark On Fri, Jan 1, 2016 at 5:49 AM, Anthony Baker wrote: > +1 > > > On Dec 30, 2015, at 9:10 PM, Roman Shaposhnik > wrote: > > > > On Mon, Dec 28, 2015 at 7:23 PM, William Markito > wrote: > >> +1 > > > > So... shall I commit? ;-) > > > > Thanks, > > Roman. > >

Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh history file

2016-01-04 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41803/#review112598 --- Ship it! Ship It! - Jinmei Liao On Dec. 30, 2015, 6:57 p.m., Je

Re: Review Request 41750: Modify all tests to use JUnit Categories

2016-01-04 Thread Kirk Lund
Right now I'm stuck as git won't let me merge the changes to develop. I'm not sure what to do next and I'm not going to experiment as that usually breaks things worse. I may have to recreate the branch and do this work over. /c/dev/gemfire_CLEAN/open [540]$ git flow feature finish -r GEODE-714 Bra

Re: LICENSE and NOTICE

2016-01-04 Thread Anthony Baker
Look on the feature/GEODE-210 branch. The source distribution versions are in the root directory. The binary distribution versions are in gemfire-assembly/src/main/dist/ Each distribution has different requirements since different external components are bundled. Anthony > On Jan 4, 2016, at 8

Re: LICENSE and NOTICE

2016-01-04 Thread Dave Barnes
Where can I find these files? On Mon, Jan 4, 2016 at 7:16 AM, Anthony Baker wrote: > I’ve made a start on our LICENSE and NOTICE files (for both source and > binary distributions) on the feature/GEODE-610 branch. Thanks to Niall for > the excellent analysis to get this started. If you’d like t

Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh history file

2016-01-04 Thread Jacob Barrett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41803/#review112592 --- Ship it! Ship It! - Jacob Barrett On Dec. 30, 2015, 10:57 a.m.,

Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh history file

2016-01-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41803/#review112591 --- Ship it! Ship It! - Kirk Lund On Dec. 30, 2015, 6:57 p.m., Jens

Re: Review Request 41803: GEODE-718: Sanitize passwords in gfsh history file

2016-01-04 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41803/#review112581 --- Ship it! Ship It! - Anthony Baker On Dec. 30, 2015, 6:57 p.m.,

LICENSE and NOTICE

2016-01-04 Thread Anthony Baker
I’ve made a start on our LICENSE and NOTICE files (for both source and binary distributions) on the feature/GEODE-610 branch. Thanks to Niall for the excellent analysis to get this started. If you’d like to contribute to this you can: 1) Review the contents of the LICENSE files and see if the