Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread anilkumar gingade
> On May 5, 2016, 9:13 p.m., Dan Smith wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java, > > line 1151 > > > > > > We're not generating event ids if there is an async event q

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46243/ --- (Updated May 6, 2016, 12:45 a.m.) Review request for geode, anilkumar gingade,

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread anilkumar gingade
> On April 19, 2016, 12:18 a.m., Dan Smith wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java, > > line 6727 > > > > > > What is this check for for isInternalRegion for? This

Re: Review Request 47046: The test code needs to be enhanced

2016-05-05 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47046/#review131976 --- Ship it! Ship It! - Dan Smith On May 5, 2016, 11:58 p.m., xi

Re: Review Request 47046: The test code needs to be enhanced

2016-05-05 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47046/ --- (Updated May 5, 2016, 11:58 p.m.) Review request for geode and Dan Smith. Cha

Re: Review Request 47046: The test code needs to be enhanced

2016-05-05 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47046/#review131963 --- Wait is deprecated. Use Awaitility. And, looking it your code, I

Review Request 47046: The test code needs to be enhanced

2016-05-05 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47046/ --- Review request for geode and Dan Smith. Bugs: geode-1183 https://issues.apa

Passed: apache/incubator-geode#474 (develop - 2da99e7)

2016-05-05 Thread Travis CI
Build Update for apache/incubator-geode - Build: #474 Status: Passed Duration: 13 minutes and 33 seconds Commit: 2da99e7 (develop) Author: Bruce Schuchardt Message: Revert "GEODE-613 CI Failure: LocatorLoadSnapshotJUnitTest.testConcurrentBalancing" This rever

Re: JIRA labels for newbies

2016-05-05 Thread William Markito
Or better yet - project = GEODE and status in (Open) and labels in (starter, gsoc2016, low-hanging-fruit, newbie, easyfix) - Total of 15 items... On Thu, May 5, 2016 at 3:03 PM, William Markito wrote: > You may find a couple of more interesting items on this query - project = > GEODE and stat

Re: JIRA labels for newbies

2016-05-05 Thread William Markito
You may find a couple of more interesting items on this query - project = GEODE and status in (Open) and labels in (starter, gsoc2016, low-hanging-fruit) https://issues.apache.org/jira/browse/GEODE-1113?jql=project%20%3D%20GEODE%20and%20status%20in%20(Open)%20and%20labels%20in%20(starter%2C%20gso

Re: Review Request 46908: GEODE-92: PR with entry eviction 1 leaves 3 entries in memory with async overflow

2016-05-05 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46908/#review131950 --- Ship it! Ship It! - Darrel Schneider On May 2, 2016, 1:40 p.

JIRA labels for newbies

2016-05-05 Thread sri man
Hi, I am new to Geode/Gemfire. Yesterday in the Geode Clubhouse I heard someone mentioning that there are 30-50 items that can be worked by newbies. The labels mentioned were “lowhangingfruit” and “GoogleSummerOfCode”. I could not find the labels in JIRA. Instead I found these beginner friendly

Re: Review Request 46916: GEODE-641: Adding default methods to the Function interface

2016-05-05 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46916/#review131934 --- Ship it! Ship It! - anilkumar gingade On May 2, 2016, 10:55

[GitHub] incubator-geode pull request: GEODE-1340: Refactored the names of ...

2016-05-05 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/141#issuecomment-217282247 +1 I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46243/#review131925 --- Nice job! I had a few comments, see below. It also might be nice

Re: Review Request 47004: a quick solution to wait for entry flushed into index

2016-05-05 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47004/#review131921 --- It seems like maybe the Flush API ought to be on the index, not th

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #300 has FAILED (2 tests failed, no failures were new)

2016-05-05 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #300 failed. --- Scheduled 2/1401 tests failed, no failures were new. https://build.spring.io/browse/SGF-NAG-300/

[GitHub] incubator-geode pull request: GEODE-1340: Refactored the names of ...

2016-05-05 Thread nabarunnag
GitHub user nabarunnag opened a pull request: https://github.com/apache/incubator-geode/pull/141 GEODE-1340: Refactored the names of lucene integration tests. * Renamed the names of integration tests to not end with JUnitTest but just IntegrationTest * Modified LuceneIndexXmlPar

Re: Review Request 46915: Add test coverage for using a custom log4j2.xml with Geode

2016-05-05 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46915/#review131876 --- Ship it! Ship It! - Jens Deppe On May 4, 2016, 11:03 p.m., K

Re: POSTED: Geode Clubhouse - Where Does Geode Fit in Modern System Architectures?

2016-05-05 Thread Gregory Chase
Greetings Geode Community, We've posted the replay of yesterday's Geode Clubhouse: https://www.youtube.com/watch?v=tOAe1n7Qyd8 -Greg On Tue, May 3, 2016 at 8:21 AM, Gregory Chase wrote: > Greetings Apache Geode Community, > This is a reminder that we're hosting a Geode Clubhouse meeting tomorro