Re: Review Request 47143: GEODE-951: repackage GemFireParameterizedMessage and GemFireParameterizedMessageFactory

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47143/#review132431 --- Ship it! Ship It! - Jens Deppe On May 10, 2016, 12:20 a.m.,

Re: Review Request 47144: GEODE-1371: delete unused log4j2-test.xml file

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47144/#review132432 --- Ship it! Ship It! - Jens Deppe On May 10, 2016, 12:23 a.m.,

Re: Review Request 47122: GEODE-1350: prepare the tests to use JunitParamsRunner

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47122/#review132434 --- Ship it! Ship It! - Jens Deppe On May 9, 2016, 3:59 p.m., Ji

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47146/#review132435 --- Ship it! Ship It! - Jens Deppe On May 10, 2016, 12:30 a.m.,

Review Request 47183: GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest

2016-05-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/ --- Review request for geode. Repository: geode Description --- GEODE-1373:

Re: Review Request 47183: GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest

2016-05-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/ --- (Updated May 10, 2016, 2:51 p.m.) Review request for geode, Jens Deppe and Kirk

Re: Review Request 47183: GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/#review132444 --- Ship it! Ship It! geode-core/src/main/java/com/gemstone/gemfi

Re: Review Request 47183: GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest

2016-05-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/ --- (Updated May 10, 2016, 2:57 p.m.) Review request for geode, Jens Deppe and Kirk

Re: Review Request 47183: GEODE-1373: resolve the shiro subject in JMX AccessControlContext firest

2016-05-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47183/ --- (Updated May 10, 2016, 3:39 p.m.) Review request for geode, Jens Deppe and Kirk

Re: Special Geode Clubhouse: Tuesday, May 10, 10AM PST: Southwest Airlines' Experience with Geode & Gemfire at Scale

2016-05-10 Thread Gregory Chase
Reminder - this amazing Geode Clubhouse session starts in 1 hour. Log in here: https://pivotalcommunity.adobeconnect.com/clubhouse/ On Sat, May 7, 2016 at 12:10 PM, Gregory Chase wrote: > Join us for a special Apache Geode Clubhouse session this Tuesday May 10. > > Brian Dunlap of Southwest Ai

Re: Review Request 47157: GEODE-1374: Add a flakyTest build task

2016-05-10 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47157/#review132460 --- I thought we were going to continue to make precheckin run these t

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

2016-05-10 Thread Kirk Lund
> On May 10, 2016, 5:36 a.m., Jinmei Liao wrote: > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/ConfigCommandsDUnitTest.java, > > line 542 > > > > > > Is this method used anymore?

RE: MultiAxisChartFX and jvsd

2016-05-10 Thread Dor Ben Dov
Any news on the jVSD and when it will be merged to the main branch ? Any thought maybe to replace the javafx with different solution maybe ? Thanks Dor -Original Message- From: Daniel Farcovich Sent: יום ג 10 מאי 2016 08:37 To: Jacob Barrett Cc: dev@geode.incubator.apache.org Subject: R

RE: MultiAxisChartFX and jvsd

2016-05-10 Thread Dor Ben Dov
Antony, It looks like replacing the javafx is the solution, unless I am missing something ? Dor From: Anthony Baker [mailto:aba...@pivotal.io] Sent: יום ב 09 מאי 2016 19:32 To: dev@geode.incubator.apache.org Subject: Re: MultiAxisChartFX and jvsd jvsd is not on the near-term roadmap proposed by

Re: MultiAxisChartFX and jvsd

2016-05-10 Thread Jacob Barrett
Do you have a suggestion for a better graphing package in Java? JavaFX graphing library is very fast and extensible. On Tue, May 10, 2016 at 9:45 AM Dor Ben Dov wrote: > Any news on the jVSD and when it will be merged to the main branch ? > Any thought maybe to replace the javafx with different

RE: MultiAxisChartFX and jvsd

2016-05-10 Thread Dor Ben Dov
Maybe replacing it with html 5, I am not saying it's 5 min work of course. But this way it will allow including it in the main line - develop / trunk branch and continue being apache license 2 - without any dependency issues. Again, it's not 5min solution of course. Dor -Original Message--

Re: MultiAxisChartFX and jvsd

2016-05-10 Thread Jacob Barrett
Are you suggesting that it be a desktop app rendering HTML 5 / JS or a web application? On Tue, May 10, 2016 at 9:49 AM Dor Ben Dov wrote: > Maybe replacing it with html 5, I am not saying it's 5 min work of course. > But this way it will allow including it in the main line - develop / trunk > b

Re: MultiAxisChartFX and jvsd

2016-05-10 Thread Jacob Barrett
BTW, the jVSD is apache 2 licensed. It is dependent on the JRE, like all other java products. The JavaFX, included with the JRE, is licensed the same as the JRE. The MultiAxisChartFX is licensed the same as the JRE. The plan is to work the changes in the chart library into the JavaFX project. On

RE: MultiAxisChartFX and jvsd

2016-05-10 Thread Dor Ben Dov
Jacob This is different answer than already being given here by Juan " Hey Dor, According to Jens (from the mail list history): The MultiAxisChartFX class is GPL code and cannot have an Apache 2.0 license attached to it. This is the reason this code was in a separate repo. A user would need to bu

Re: MultiAxisChartFX and jvsd

2016-05-10 Thread Jacob Barrett
I don't see the contradiction. MultiAxisChartFX is GPL with class path exception like the JDK. It cannot be relicensed to Apache 2.0. Per ASF rules it may not be shipped as part of the binary distribution either. The library can be downloaded separately, like the JDK, to run the jVSD application.

Review Request 47187: GEODE-17: make sure commands tests are run in useHttp mode.

2016-05-10 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47187/ --- Review request for geode, Jens Deppe and Kirk Lund. Repository: geode Descrip

Review Request 47189: GEODE-1375 When using multicast a new member needs to receive the multicast message digest

2016-05-10 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47189/ --- Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. Rep

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #305 was SUCCESSFUL (with 1396 tests)

2016-05-10 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #305 was successful. --- Scheduled 1398 tests in total. https://build.spring.io/browse/SGF-NAG-305/ -- This

Re: Review Request 47148: GEODE-11: Adding package level javadocs for lucene

2016-05-10 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47148/#review132530 --- Ship it! Ship It! - xiaojian zhou On May 10, 2016, 1:13 a.m.

Review Request 47191: removed DataAsAddress references

2016-05-10 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47191/ --- Review request for geode, Eric Shu and Ken Howe. Bugs: GEODE-1356 https://i

Re: Review Request 47128: add release call when GatewaySenderEventImpl removed from tempQueue

2016-05-10 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47128/#review132545 --- Ship it! OK, that's pretty straight forward - Ken Howe On M

Moving to JUnit 4.13-SNAPSHOT

2016-05-10 Thread Jens Deppe
Kirk recently found that test classes annotated with both @Category and @Parameterized (both standard JUnit annotations) result in tests being skipped [1] It appears that JUnit 4.13-SNAPSHOT fixes the issue. Does anyone have any aversion to using a 'SNAPSHOT' release for junit? An alternative is

Re: Review Request 47146: GEODE-1369: change ConfigCommandsDUnitTest to use TemporaryFolder

2016-05-10 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47146/#review132549 --- Ship it! Ship It! - Kevin Duling On May 9, 2016, 5:30 p.m.,

Re: Review Request 47191: removed DataAsAddress references

2016-05-10 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47191/#review132550 --- Ship it! Ship It! - Eric Shu On May 10, 2016, 9:41 p.m., Dar

Re: Review Request 47191: removed DataAsAddress references

2016-05-10 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47191/#review132552 --- Ship it! Ship It! - Ken Howe On May 10, 2016, 9:41 p.m., Dar

Re: Review Request 47187: GEODE-17: make sure commands tests are run in useHttp mode.

2016-05-10 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47187/#review132553 --- Ship it! Ship It! - Jens Deppe On May 10, 2016, 8:05 p.m., J

Re: Review Request 47128: add release call when GatewaySenderEventImpl removed from tempQueue

2016-05-10 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47128/#review132556 --- Ship it! Ship It! - Eric Shu On May 9, 2016, 5:32 p.m., Darr

Review Request 47194: javadocs now make clear that off-heap regions always clone

2016-05-10 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47194/ --- Review request for geode, Ken Howe and Sai Boorlagadda. Bugs: GEODE-1379 ht

Re: Moving to JUnit 4.13-SNAPSHOT

2016-05-10 Thread Dan Smith
If we switch to a snapshot release, that means the version of junit will be a moving target, right? So if someone checks a breaking change into junit all of our builds will fail. Or worse, not fail. I'm not sure if that's state we want to be in. -Dan On Tue, May 10, 2016 at 2:54 PM, Jens Deppe w

Review Request 47195: GEODE-699 PartitionedRegionSingleHopDUnitTest.test_MetadataServiceCallAccuracy

2016-05-10 Thread Jianxia Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47195/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 47194: javadocs now make clear that off-heap regions always clone

2016-05-10 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47194/#review132564 --- Ship it! Ship It! - Ken Howe On May 10, 2016, 10:44 p.m., Da

Re: Moving to JUnit 4.13-SNAPSHOT

2016-05-10 Thread Dan Smith
Looking at the fix a little bit, I think we can work around this with the current version of junit with something like this. We just need to create our own runner factory that will return the correct annotations.

Review Request 47201: removed @Retained from getValueInVM since its result is never off-heap

2016-05-10 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47201/ --- Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda. Bugs: GEODE-

Re: Moving to JUnit 4.13-SNAPSHOT

2016-05-10 Thread Mark Bretl
I agree with Dan that depending on a SNAPSHOT version is probably not the best, especially when it is a major part running our tests. This could have problems when no developers change anything but JUnit releases a new snapshot and the nightly build uses the newest release resulting in new failures

Re: Moving to JUnit 4.13-SNAPSHOT

2016-05-10 Thread Kirk Lund
Let's talk more about the workaround tomorrow to determine how easy and reusable that might be. We could also reach out to the JUnit community to get a possible ETA for releasing 4.13. -Kirk On Tue, May 10, 2016 at 4:48 PM, Mark Bretl wrote: > I agree with Dan that depending on a SNAPSHOT ver

Updated M3 release page

2016-05-10 Thread William Markito
Just updated M3 release page and JIRA issues. [1] Updated 1.0.0 items as per our previous discussion [2] as well and created a release page [3] as a placeholder and to provide an idea of the upcoming items. Let the sprint being... ;) [1] https://cwiki.apache.org/confluence/display/GEODE/1.0.0-in

Build failed in Jenkins: Geode-nightly #465

2016-05-10 Thread Apache Jenkins Server
See Changes: [jdeppe] GEODE-1255: Revert some changes which had broken the build [bschuchardt] GEODE-1346: Typo "Emtpy" affects Exception name and some help strings [upthewaterspout] GEODE-1340: Refactored the names of lucene integratio

Review Request 47220: This is bug in test code

2016-05-10 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47220/ --- Review request for geode and anilkumar gingade. Bugs: geode-1344 https://is