[GitHub] incubator-geode pull request: GEODE-748: Unexpected version string...

Github user jdeppe-pivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/148#issuecomment-221445749 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Review Request 47803: field value could be null, need to handle this case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47803/#review134667 --- Ship it! Ship It! - Dan Smith On May 25, 2016, 12:20 a.m.,

Review Request 47803: field value could be null, need to handle this case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47803/ --- Review request for geode and Dan Smith. Bugs: GEODE-1453

Re: Review Request 47796: fix callback arg parameter order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47796/#review134658 --- Ship it! Ship It! - Scott Jewell On May 24, 2016, 9:47

[GitHub] incubator-geode pull request: GEODE-1413: Replaced wait with await...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: GEODE-1121: Reduced the memory confi...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 47796: fix callback arg parameter order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47796/#review134654 --- Ship it! Ship It! - Ken Howe On May 24, 2016, 9:47 p.m.,

[GitHub] incubator-geode pull request: GEODE-1121: Reduced the memory confi...

Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/147#issuecomment-221422193 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review134650 ---

Re: Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/#review134647 ---

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47543/ --- (Updated May 24, 2016, 10:05 p.m.) Review request for geode, Darrel Schneider

Re: Review Request 47744: deliver event synchronously if it is rejected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47744/#review134645 --- Ship it! Neglected to click Ship It! when I revoewed this last

Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47686/#review134641 --- Fix it, then Ship it!

Review Request 47793: GEODE-93: Entry count stats are incorrect with PR with entry eviction and async disk

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47793/ --- Review request for geode, Darrel Schneider, Eric Shu, Scott Jewell, and Ken

Re: Review Request 47479: GEODE-1296: change conditional in getRawBytes to assert

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47479/#review134644 --- Ship it! Ship It! - Sai Boorlagadda On May 17, 2016, 5:22

Re: Review Request 47678: Preventing the sequence logger from launching and closing a thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47678/#review134643 --- Ship it! Ship It! - Scott Jewell On May 20, 2016, 10:40

Re: Review Request 47479: GEODE-1296: change conditional in getRawBytes to assert

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47479/#review134642 --- Ship it! Ship It! - Scott Jewell On May 17, 2016, 5:22

Re: Review Request 47744: deliver event synchronously if it is rejected

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47744/#review134640 --- Ship it! Ship It! - Scott Jewell On May 23, 2016, 10:36

Re: Review Request 47712: test perfield analyzer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47712/#review134621 --- Fix it, then Ship it! Looks good, and thank for the fix to the

Re: Review Request 47745: remove sqlf code in GemFireCacheImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47745/#review134629 --- Ship it! Ship It! - Sai Boorlagadda On May 23, 2016, 10:41

[GitHub] incubator-geode pull request: GEODE-1121: Reduced the memory confi...

GitHub user nabarunnag opened a pull request: https://github.com/apache/incubator-geode/pull/147 GEODE-1121: Reduced the memory configurations in the overflow tests. * Reduced the sender's max memory to 1MB. * Reduced the amount of puts to 5MB. * Introduced a listener to

[GitHub] incubator-geode pull request: GEODE-1121: Increased the max memory...

Github user nabarunnag closed the pull request at: https://github.com/apache/incubator-geode/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request: GEODE-1121: Increased the max memory...

GitHub user nabarunnag reopened a pull request: https://github.com/apache/incubator-geode/pull/139 GEODE-1121: Increased the max memory in the sender * Increased the max memory in the sender to be 100MB * Reduced the puts to 120MB * Made the test identical to the one in

[GitHub] incubator-geode pull request: GEODE-1121: Increased the max memory...

Github user nabarunnag closed the pull request at: https://github.com/apache/incubator-geode/pull/139 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Review Request 47784: GEODE-1410: Fix artifacts published for modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47784/#review134623 --- Ship it! Ship It! - Mark Bretl On May 24, 2016, 10:57 a.m.,

Re: Review Request 47784: GEODE-1410: Fix artifacts published for modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47784/#review134620 --- Ship it! Ship It! - Dan Smith On May 24, 2016, 5:57 p.m.,

[GitHub] incubator-geode pull request: GEODE-1413: Replaced wait with await...

Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/pull/146#issuecomment-221376610 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Review Request 47745: remove sqlf code in GemFireCacheImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47745/#review134613 ---

[GitHub] incubator-geode pull request: GEODE-1413: Replaced wait with await...

GitHub user nabarunnag opened a pull request: https://github.com/apache/incubator-geode/pull/146 GEODE-1413: Replaced wait with awaitility clause on receiver regionSize * Replaced the wait for 2 seconds with awaitility clause which waits for the receiver region size to become the

Review Request 47784: GEODE-1410: Fix artifacts published for modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47784/ --- Review request for geode, Bruce Schuchardt, Jinmei Liao, Kevin Duling, Kirk

Re: Review Request 47748: change isEmpty to use size

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47748/#review134612 --- Ship it! I understand the reasoning behind the test

Re: Review Request 47748: change isEmpty to use size

> On May 24, 2016, 10:18 a.m., Ken Howe wrote: > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LocalDataSetTest.java, > > line 37 > > > > > > Is it necesary to mock pr.isEmpty()? With the change in

Re: Review Request 47748: change isEmpty to use size

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47748/#review134604 ---

Re: Review Request 47748: change isEmpty to use size

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47748/ --- (Updated May 24, 2016, 9:22 a.m.) Review request for geode, Scott Jewell and

Re: Review Request 47740: GEODE-17: create muti-user security DUnit tests

> On May 24, 2016, 2:32 p.m., Jens Deppe wrote: > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/SecurityDUnitTest.java, > > line 42 > > > > > > This class should probably include

Re: Review Request 47740: GEODE-17: create muti-user security DUnit tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47740/#review134583 --- Fix it, then Ship it! Ship It!

Build failed in Jenkins: Geode-nightly #478

See Changes: [jiliao] GEODE-17: change default regionName to * instead of null. [jdeppe] GEODE-695: Unable to export cluster config on Windows [klund] GEODE-1431: Fix GfshParserJUnitTest failure [ukohlmeyer] GEODE-1367: Replaced