Re: Snappy compressor (native->java)

2016-06-20 Thread Darrel Schneider
+1 A problem with the native bits is this product feature only works on certain native platforms. On Mon, Jun 20, 2016 at 7:48 PM, Sai Boorlagadda wrote: > There were no problems on the JNI wrapper (with native bits) except that > maintaining native bits needs

Re: Snappy compressor (native->java)

2016-06-20 Thread Sai Boorlagadda
There were no problems on the JNI wrapper (with native bits) except that maintaining native bits needs special development & testing efforts than pure java one. On Mon, Jun 20, 2016 at 5:52 PM, Dan Smith wrote: > +0 If the native code is causing problems switching seems like

Re: Snappy compressor (native->java)

2016-06-20 Thread Dan Smith
+0 If the native code is causing problems switching seems like a good idea. I would suggest looking into embedding the native bits into a JAR file. > There are some tricks you can do to write the native bits out to disk from > the JAR file to load them at runtime. This would make it easier for

Re: Snappy compressor (native->java)

2016-06-20 Thread Michael Stolz
+1 pure java -- Mike Stolz Principal Engineer - Gemfire Product Manager Mobile: 631-835-4771 On Jun 20, 2016 4:58 PM, "Jacob Barrett" wrote: > +1 for pure java default and making the native a drop in option. > > I would suggest looking into embedding the native bits into a

Re: Snappy compressor (native->java)

2016-06-20 Thread Jacob Barrett
+1 for pure java default and making the native a drop in option. I would suggest looking into embedding the native bits into a JAR file. There are some tricks you can do to write the native bits out to disk from the JAR file to load them at runtime. This would make it easier for someone to deploy

[GitHub] incubator-geode pull request #168: GEODE-1557: Not logging BucketNotFoundExc...

2016-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode issue #168: GEODE-1557: Not logging BucketNotFoundException

2016-06-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/168 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] incubator-geode pull request #168: GEODE-1557: Not logging BucketNotFoundExc...

2016-06-20 Thread nabarunnag
Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/168#discussion_r67784199 --- Diff: geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneEventListenerJUnitTest.java --- @@ -99,4 +105,19 @@ public

Snappy compressor (native->java)

2016-06-20 Thread Sai Boorlagadda
Geode currently bundles xerial/snappy as a default implementation. And this is a "JNI wrapper" on google snappy implementation. "xerial/snappy" jar bundles several pre-compiled static libraries to support various OS (linux,

[GitHub] incubator-geode pull request #169: GEODE-11: Added findKeys, findValues and ...

2016-06-20 Thread aparnard
GitHub user aparnard opened a pull request: https://github.com/apache/incubator-geode/pull/169 GEODE-11: Added findKeys, findValues and findResults to LuceneQuery Renamed LuceneQueryResults to PageableLuceneQueryResults and search to findPages. Added the findKeys method to

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #346 has FAILED

2016-06-20 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #346 failed. --- Scheduled No failed tests found, a possible compilation error.

Re: Review Request 48889: GEODE-1493: config/gemfire.properties that is shipped with the geode distribution contains user specific info

2016-06-20 Thread Sai Boorlagadda
> On June 20, 2016, 5:59 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java, > > line 283 > > > > > > How is this change related to

Tests annotated with @FlakyTest with bugs marked resolved

2016-06-20 Thread Dan Smith
With the changes for GEODE-1374, I wanted to double check that we actually have open issues for all of the tickets marked flaky in the source. It turns out a lot of the bug numbers mentioned in the @Flaky annotations are actually closed. I created a query that shows all of closed issues with

Re: Review Request 48965: add a test case to run query on client

2016-06-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48965/#review138669 --- Hi Gester, Nice, thanks for adding a test! But I think it would

Re: Review Request 48965: add a test case to run query on client

2016-06-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48965/ --- (Updated June 20, 2016, 8:31 p.m.) Review request for geode and Dan Smith.

Review Request 48965: add a test case to run query on client

2016-06-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48965/ --- Review request for geode and Dan Smith. Bugs: GEODE-1572

Re: Review Request 48889: GEODE-1493: config/gemfire.properties that is shipped with the geode distribution contains user specific info

2016-06-20 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48889/#review138646 ---

Re: Some proposed changes to the geode lucene search API

2016-06-20 Thread Anilkumar Gingade
+1 To be clear we are removing "search()" and replacing this with methods that reflect the return types... E.g: findKeys() - Returns only the region keys for matched query. This provides applications flexibility of working with only keys or to fetch region values as required. -Anil. On Mon,

Some proposed changes to the geode lucene search API

2016-06-20 Thread Dan Smith
Hi team, The lucene integration work is still ongoing. We'd like to make a few changes to the API that was proposed on the wiki. The proposal is to add a few more methods to the LuceneQuery class to return different types of results: LuceneQuery { Collection findKeys(); Collection

Re: Review Request 48916: GEODE-1567: fix HelpCommandsIntegrationTest failure

2016-06-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48916/#review138623 --- Ship it! Ship It! - Jinmei Liao On June 18, 2016, 10:11

Re: Review Request 48916: GEODE-1567: fix HelpCommandsIntegrationTest failure

2016-06-20 Thread Grace Meilen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48916/#review138618 --- Ship it! Ship It! - Grace Meilen On June 18, 2016, 10:11

[GitHub] incubator-geode pull request #160: GEODE-1525: Examples README.md should set...

2016-06-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Build failed in Jenkins: Geode-nightly #505

2016-06-20 Thread Apache Jenkins Server
See -- [...truncated 794 lines...] Required: false Default (if the parameter is specified without value): __DEFAULT__] async-event-que...> but was:<...ied without value):