Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-11 Thread anilkumar gingade
> On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > Jason, Thanks for the review...Good points... > On Aug. 11, 2016, 11:16 p.m., Jason Huynh wrote: > > geode-core/src/test/java/com/gemstone/gemfire/test/dunit/rules/LocatorServerConfigurationRule.java, > > line 82 > >

Review Request 51018: fix diskStats and prStats related to entry count and data size

2016-08-11 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51018/ --- Review request for geode, Eric Shu, Scott Jewell, and Ken Howe. Bugs: GEODE-171

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #398 was SUCCESSFUL (with 1423 tests)

2016-08-11 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #398 was successful. --- Scheduled 1425 tests in total. https://build.spring.io/browse/SGF-NAG-398/ -- This

Re: Geode M3 docs: Review opportunity

2016-08-11 Thread Dave Barnes
This version of the Geode User Manual has been posted to the public site: http://geode.docs.pivotal.io/ On Wed, Aug 10, 2016 at 1:15 PM, William Markito wrote: > LGTM. +1 > > Thanks Dave! > > On Mon, Aug 8, 2016 at 11:40 AM, Dave Barnes wrote: > > > I've posted the Geode User docs for the up

Re: Revised SSL properties failure scenario advice.

2016-08-11 Thread Darrel Schneider
how does ssl-default-alias interact with this one in the spec: ssl-certificate-alias=[empty,string] (default - use first cert in keystore) I thought ssl-certificate-alias was the one to use by default. It could be overridden by a component one. And the default for it is to use the first certific

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

2016-08-11 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50715/#review145536 --- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/Colo

Review Request 50967: GEODE-599: CI Failure: DistributedAckPersistentRegionCCEDUnitTest.testClearWithConcurrentEventsAsync

2016-08-11 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50967/ --- Review request for geode, Darrel Schneider, Eric Shu, and Ken Howe. Repository:

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

2016-08-11 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50715/ --- (Updated Aug. 11, 2016, 5:51 p.m.) Review request for geode, Darrel Schneider,

Re: Experimental features for 1.0

2016-08-11 Thread William Markito
Cool! I'll take a stab looking current stuff in develop and already opened tickets. On Thu, Aug 11, 2016 at 9:39 AM, Anthony Baker wrote: > I think that is the relevant point. We are making releases from develop, > not from WIP branches. > > @John, HDFS was moved to a WIP branch. > > Anthony >

Re: Experimental features for 1.0

2016-08-11 Thread Anthony Baker
I think that is the relevant point. We are making releases from develop, not from WIP branches. @John, HDFS was moved to a WIP branch. Anthony > On Aug 11, 2016, at 9:31 AM, Kirk Lund wrote: > > JVSD is not on develop, so maybe not. We probably only need to annotate and > file tickets for in

Re: Experimental features for 1.0

2016-08-11 Thread Kirk Lund
JVSD is not on develop, so maybe not. We probably only need to annotate and file tickets for incomplete features on develop. -Kirk On Wed, Aug 10, 2016 at 10:35 PM, Dave Barnes wrote: > JVSD is not fully-featured, yet. Does it belong on the list? > > > On Aug 10, 2016, at 6:26 PM, Kirk Lund w

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-11 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/230 No existing test exposed this. This is in reaction to a code analysis. Case by case, the code may or may not be doing what the developer intended because of the nature of == vs .equals().