[GitHub] incubator-geode pull request: GEODE-342: Make changes to Geode gra...

2016-01-14 Thread vfordpivotal
Github user vfordpivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/71#issuecomment-171751700 Reviewing the changes. The main issues might be the inclusion in the build process the cloning and building of the MultiAxisChartFX as the gpl license may

[GitHub] incubator-geode pull request: GEODE-341/ GEODE-628: Refactor Java ...

2016-01-13 Thread vfordpivotal
Github user vfordpivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/49#issuecomment-171368319 The changes have been pushed to the Apache repo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-geode pull request: GEODE-341/ GEODE-628: Refactor Java ...

2016-01-12 Thread vfordpivotal
Github user vfordpivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/49#issuecomment-171101247 The changes look good, I will pull them to my local repo and do a final review. I expect to push them tomorrow if everything is as expected. --- If your

[GitHub] incubator-geode pull request: GEODE-341: Refactor Java packages to...

2015-12-04 Thread vfordpivotal
Github user vfordpivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/46#issuecomment-162039056 A number of the pom.xml dependencies removed will need to be re-added as they will be needed for testing (creating stats files...) which at present is