GitHub user jujoramos opened a pull request:
https://github.com/apache/incubator-geode/pull/71
GEODE-342: Make changes to Geode gradle build script to also build JVSD
- Switched from maven to gradle.
- Modified global gradle script to include geode-jvsd in the build and
distribu
Github user vfordpivotal commented on the pull request:
https://github.com/apache/incubator-geode/pull/71#issuecomment-171751700
Reviewing the changes. The main issues might be the inclusion in the build
process the cloning and building of the MultiAxisChartFX as the gpl license may
b
Github user jujoramos commented on the pull request:
https://github.com/apache/incubator-geode/pull/71#issuecomment-171934710
Hey Vince,
Thanks for reviewing the pull request.
I knew about the license problem regarding project MultiAxisChartFX but
we'll need to create a new JIR
Github user jujoramos commented on the pull request:
https://github.com/apache/incubator-geode/pull/71#issuecomment-185093557
Hey Vincent,
I have the option to close the pull request from my GitHub account, do you
want me to close it?. Or doing so implies some type of history loosi
Github user jdeppe-pivotal commented on the pull request:
https://github.com/apache/incubator-geode/pull/71#issuecomment-185740062
Go ahead and close this - it's been integrated already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user jujoramos commented on the pull request:
https://github.com/apache/incubator-geode/pull/71#issuecomment-185740756
Thanks Jens,
It's done, cheers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user jujoramos closed the pull request at:
https://github.com/apache/incubator-geode/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
