[GitHub] incubator-geode pull request: GEODE-712: Move junit asserts out of...

2016-01-06 Thread dschneider-pivotal
Github user dschneider-pivotal commented on the pull request: https://github.com/apache/incubator-geode/pull/68#issuecomment-169497119 This change looks good and the modified unit test still passes --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] incubator-geode pull request: GEODE-712: Move junit asserts out of...

2016-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-geode pull request: GEODE-712: Move junit asserts out of...

2016-01-06 Thread gemzdude
GitHub user gemzdude opened a pull request: https://github.com/apache/incubator-geode/pull/68 GEODE-712: Move junit asserts out of finally block This change prevents the assert in the finally block from "swallowing" the thrown exception. The next time this test fails, we can reo