Re: DistributionConfig and Geode system properties

++1 - This is really good! On Thu, Jun 2, 2016 at 12:16 PM, Udo Kohlmeyer wrote: > John: Perhaps the (interface) name can be simplified to > ConfigurationProperties too. > > Funnily enough I initially had called it SystemConfigurationProperties, > but later renamed it because it felt too gener

Re: DistributionConfig and Geode system properties

John: Perhaps the (interface) name can be simplified to ConfigurationProperties too. Funnily enough I initially had called it SystemConfigurationProperties, but later renamed it because it felt too generic. Dan: 3) DistributedSystem has a ton of javadocs describing each property and what it

Re: DistributionConfig and Geode system properties

+1 to naming it "ConfigurationProperties" +1 to moving the javadocs On Thu, Jun 2, 2016 at 10:46 AM, John Blum wrote: > Perhaps the (interface) name can be simplified to ConfigurationProperties > too. Not all properties necessarily involve specifically the distributed > system configuration, b

Re: DistributionConfig and Geode system properties

Perhaps the (interface) name can be simplified to ConfigurationProperties too. Not all properties necessarily involve specifically the distributed system configuration, but rather the overall Geode system configuration (Cache, Management, HTTP Service(s), Clients, etc). On Thu, Jun 2, 2016 at 10:

Re: DistributionConfig and Geode system properties

+1 for moving the javadocs Also, CacheFactory has two methods that should point to this new class: CacheFactory(Properties) and set(String,String). Le 6/2/2016 à 10:27 AM, Dan Smith a écrit : 3) DistributedSystem has a ton of javadocs describing each property and what it does. I wonder if th

Re: DistributionConfig and Geode system properties

First off - nice job, these constants should have been available a long time ago! One question a couple of comments: 1) Is the idea with the change that all code should reference the constants in DistributedSystemConfigProperties. For example, I should use DistributedSystemConfigProperties.CACHE_

Re: DistributionConfig and Geode system properties

Since this an addition to the public API (albeit small) please make sure to review and offer feedback. We should consider how future changes (property additions, removals, renames, defaults) will impact backwards compatibility. Thanks, Anthony > On Jun 1, 2016, at 5:17 PM, Udo Kohlmeyer wrote

DistributionConfig and Geode system properties

Hi there, As per GEODE-1377 I've refactored DistributionConfig to extract all public system properties into a public DistributedSystemConfigProperties interface. With that refactor I've touched a significant amount of classed and I, in advan