Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-11-02 Thread Dick Cavender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104832 --- Ship it! Ship It! - Dick Cavender On Oct. 28, 2015, 4:29 a.m.,

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-10-28 Thread Nitin Lamba
> On Oct. 28, 2015, 4:12 p.m., Tushar Khairnar wrote: > > One thing Dan observed is that eclipse files (.classpath, .project) are > > checked in git but they should not be can you add gitignore entries for > > them and remove them from git tracking Sure, will delete those from repo and add to

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-10-28 Thread Tushar Khairnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104301 --- One thing Dan observed is that eclipse files (.classpath, .project)

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests

2015-10-27 Thread Nitin Lamba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/ --- (Updated Oct. 28, 2015, 4:29 a.m.) Review request for geode, Dick Cavender, Tus

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-27 Thread Nitin Lamba
> On Oct. 19, 2015, 7:14 p.m., Mark Bretl wrote: > > pulse/build.gradle, line 43 > > > > > > gemfire-core is using version 4.12. Can the version be upgraded from > > 4.10 to 4.12? > > Nitin Lamba wrote: > I'm no

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-27 Thread Nitin Lamba
> On Oct. 27, 2015, 10:43 a.m., Tushar Khairnar wrote: > > pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/JMXDataUpdater.java, > > line 2350 > > > > > > We can Remove gemXD realated code completel

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-27 Thread Tushar Khairnar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review104160 --- pulse/src/main/java/com/vmware/gemfire/tools/pulse/internal/data/J

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-20 Thread Nitin Lamba
> On Oct. 19, 2015, 7:14 p.m., Mark Bretl wrote: > > pulse/build.gradle, line 43 > > > > > > gemfire-core is using version 4.12. Can the version be upgraded from > > 4.10 to 4.12? I'm not actively using junit in cod

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-19 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review103144 --- pulse/build.gradle (line 40)

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-19 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/#review103141 --- Ship it! Ship It! - Dan Smith On Oct. 19, 2015, 6:35 p.m., Niti

Re: Review Request 39445: GEODE-12/GEODE-304 Fix Pulse tests (WIP)

2015-10-19 Thread Nitin Lamba
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39445/ --- (Updated Oct. 19, 2015, 6:35 p.m.) Review request for geode, Dick Cavender, Tus