Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45162/#review124914 --- Ship it! Ship It! - Barry Oglesby On March 22, 2016, 10:29 p

Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45162/ --- (Updated March 22, 2016, 10:29 p.m.) Review request for geode, anilkumar gingad

Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

> On March 22, 2016, 6:36 p.m., Dan Smith wrote: > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java, > > line 130 > > > > > > Remove debugging comm

Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

> On March 22, 2016, 6:31 p.m., Barry Oglesby wrote: > > I'm not sure how this fixes the original bug, but it does fix the > > BatchRemovalThreads being left running. > > > > Can you also change this code to not call getQueues 3 times: > > > > From: > > > > if (getQueues() != null && !get

Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45162/#review124852 --- Fix it, then Ship it! Looks good, just remove some commented ou

Re: Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45162/#review124851 --- I'm not sure how this fixes the original bug, but it does fix the

Review Request 45162: GEODE-911: Cleaning up SerialGatewaySender queues when stopping gateway

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45162/ --- Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smi