Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

It will be even better to provide it as a public API, then the real implementation could be put into LuceneIndexForPartitionedRegion. Just be conservative, I suggested to put into LuceneIndexImpl as a internal API. What I really want is a public API. On Tue, May 31, 2016 at 4:28 PM, Dan Smith

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

> On May 31, 2016, 11:01 p.m., xiaojian zhou wrote: > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java, > > line 49 > > > > > > This feature

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

> On May 31, 2016, 9:19 p.m., Jason Huynh wrote: > > Not sure how important it will be but maybe a test for an invalid function > > argument (such as a bad location or a null location?) Sounds good, I'll add one > On May 31, 2016, 9:19 p.m., Jason Huynh wrote: > >

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48086/#review135709 ---

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48086/#review135684 --- Not sure how important it will be but maybe a test for an invalid

Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48086/ --- Review request for geode, Jason Huynh, nabarun nag, and xiaojian zhou.