Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-03 Thread Eric Shu
> On June 2, 2016, 10:58 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java, > > line 1024 > > > > > > failoverMap is synchronized but this code does n

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- (Updated June 3, 2016, 12:05 a.m.) Review request for geode, Darrel Schneider a

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/#review136004 --- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXMa

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/#review136005 --- Ship it! Ship It! - Swapnil Bawaskar On June 2, 2016, 9:33 p

Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- Review request for geode, Darrel Schneider and Swapnil Bawaskar. Bugs: GEODE-14

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

2016-06-02 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48187/ --- (Updated June 2, 2016, 9:33 p.m.) Review request for geode, Darrel Schneider an