Re: Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48695/#review137557 --- Ship it! Ship It! - Dan Smith On June 14, 2016, 5:41 p.m., J

Re: Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48695/ --- (Updated June 14, 2016, 5:41 p.m.) Review request for geode, anilkumar gingade,

Re: Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Jason Huynh
> On June 14, 2016, 4:55 p.m., Dan Smith wrote: > > Hi Jason, > > > > It looks good, but I think the LuceneQueryProvider should not be passed a > > default field. The APIs on LuceneQueryFactory should be: > > > > create(String index, String region, String query, String defaultField) > > create

Re: Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Jason Huynh
> On June 14, 2016, 4:55 p.m., Dan Smith wrote: > > Hi Jason, > > > > It looks good, but I think the LuceneQueryProvider should not be passed a > > default field. The APIs on LuceneQueryFactory should be: > > > > create(String index, String region, String query, String defaultField) > > create

Re: Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48695/#review137537 --- Hi Jason, It looks good, but I think the LuceneQueryProvider shou

Review Request 48695: Allows passing in a defaultField into the query search

2016-06-14 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48695/ --- Review request for geode, anilkumar gingade, nabarun nag, Dan Smith, and xiaojia