Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-07-07 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/#review141188 --- Fix it, then Ship it! Ship It!

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-07-06 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/ --- (Updated July 6, 2016, 8:42 p.m.) Review request for geode, anilkumar gingade,

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-30 Thread nabarun nag
> On June 30, 2016, 11:14 p.m., nabarun nag wrote: > > geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java, > > line 303 > > > > > > Hi Jason, > > While

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-30 Thread nabarun nag
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/#review140264 ---

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-30 Thread Jason Huynh
> On June 29, 2016, 9:02 p.m., anilkumar gingade wrote: > > Nice to have unit test for this. Agreed, however this would require quite a few test hooks in product code. There are multiple scenarios that can cause this issue. I've inserted a "test case" to the ticket that will reproduce the

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-29 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/#review140051 --- Ship it! Nice to have unit test for this. - anilkumar gingade

Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-22 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/ --- Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan