On Aug 20, 2014, at 10:23 AM, Romain Manni-Bucau wrote:
> The main changes are:
[...]
> skip java.* classes since we'll not get their bytecode for sure
> (protected method if needed)
I'm not a fan of hard coding filtering inside the AnnotationFinder itself, so
+1 under the condition that we rem
@David: it was filtering java.lang.Object since it was created, java.*
filter just extend this logic since it will never works (excepted if
you bring java.* in your app which is unlikely. That said method is
protected to be able to override it.
In all case (I think I mentionned it several times)
Counting votes it seems it passed:
+1s: Alan D Cabrera, David Blevins, Romain Manni-Bucau
+0: Jean-Baptiste Onofré, Mark Struberg
-1: no
thank you all for your votes.
PS: ones having identified some issues would be welcomed to at least
open a jira explaining it and potentially proposing a fix i
On Aug 25, 2014, at 9:43 AM, Romain Manni-Bucau wrote:
> PS: ones having identified some issues would be welcomed to at least
> open a jira explaining it and potentially proposing a fix if you
> already have an idea to not forget them for 4.1
Nicely phrased. And +1 on the welcome nudges.
-Davi
And Thank You for the vote!!
--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com
On Aug 25, 2014, at 9:43 AM, Romain Manni-Bucau wrote:
> Counting votes it seems it passed:
>
> +1s: Alan D Cabrera, David Blevins, Romain Manni-Bucau
> +0: Jean-Baptiste Onofré, Mark Struberg
