Re: Microprofile OpenAPI

2018-11-30 Thread Raymond Auge
I do personally find it very weird that MP spec would prefer YAML over JSON when there is no YAML otherwise defined as part of the MP profile! If I wanted to build a minimal MP it means I have to add a YAML impl when the stack already defines JSON to be part of the stack? It makes little sense.

Re: Microprofile OpenAPI

2018-11-30 Thread Ivan Junckes Filho
On Fri, Nov 30, 2018 at 2:34 PM Richard Monson-Haefel < monsonhae...@gmail.com> wrote: > When you are setting up a MP Rest Client, there are certain annotations > that are required, right? Is it possible to have the TomEE code detect > these MP annotations and change the default to yaml

Re: Microprofile OpenAPI

2018-11-30 Thread Romain Manni-Bucau
Well, I don't aim to have an argument here but please also consider that I can ask as well why you (not sure who is "people" cause I see mainly 1 voice here which vendor voice) woudln't respect user feedback which is regularly pro json in several companies - I know the spec picked yaml for

Re: Microprofile OpenAPI

2018-11-30 Thread Ivan Junckes Filho
The goal for this is to implement Microprofile Specifications. So what the Microprofile community decides is important and needs to be followed. Of course everyone has a voice there and you clearly spoke up there which is great. You think it is not the best approach, but people there until now

Re: Microprofile OpenAPI

2018-11-30 Thread Ivan Junckes Filho
This is against the spec as well, yaml is required and must always be default. Do we really want to let our implementation not compatible with that? On Fri, Nov 30, 2018 at 2:03 PM Romain Manni-Bucau wrote: > If jackson yaml is present it will add a (jackson) writer for yaml, if not > it stays

Re: Microprofile OpenAPI

2018-11-30 Thread Romain Manni-Bucau
I don't understand why you say so Ivan, it is perfectly compatible. Also to answer clearly to your question: I prefer to have an impl not compatible with the spec when the spec says something stupid, most of the time we put toggle to be able to be compatible but sometimes there is not even a way

Re: Microprofile OpenAPI

2018-11-30 Thread Romain Manni-Bucau
If jackson yaml is present it will add a (jackson) writer for yaml, if not it stays on json. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github |

Re: Microprofile OpenAPI

2018-11-30 Thread Ivan Junckes Filho
@Romain Manni-Bucau not sure I understood you. Are you saying you will work to make it compatible with the spec? Have yaml as default? On Fri, Nov 30, 2018 at 1:30 PM César Hernández Mendoza < cesargu...@gmail.com> wrote: > > > > I think regardless of what the MicroProfile team decides, we need

[jira] [Created] (GERONIMO-6660) [openapi] default yaml serializer is broken

2018-11-30 Thread Romain Manni-Bucau (JIRA)
Romain Manni-Bucau created GERONIMO-6660: Summary: [openapi] default yaml serializer is broken Key: GERONIMO-6660 URL: https://issues.apache.org/jira/browse/GERONIMO-6660 Project: Geronimo

[jira] [Resolved] (GERONIMO-6660) [openapi] default yaml serializer is broken

2018-11-30 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved GERONIMO-6660. -- Resolution: Fixed > [openapi] default yaml serializer is broken >

[jira] [Resolved] (GERONIMO-6659) Provide base for a yaml provider and make the default mediatype configurable

2018-11-30 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved GERONIMO-6659. -- Resolution: Fixed > Provide base for a yaml provider and make the default

[jira] [Created] (GERONIMO-6659) Provide base for a yaml provider and make the default mediatype configurable

2018-11-30 Thread Romain Manni-Bucau (JIRA)
Romain Manni-Bucau created GERONIMO-6659: Summary: Provide base for a yaml provider and make the default mediatype configurable Key: GERONIMO-6659 URL: https://issues.apache.org/jira/browse/GERONIMO-6659

Re: Microprofile OpenAPI

2018-11-30 Thread Romain Manni-Bucau
I'll add */* for yaml endpoint to complement text/plain, this will solve the ambiguity Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

[jira] [Resolved] (GERONIMO-6658) Issue @Gauge Accept: application/json

2018-11-30 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau resolved GERONIMO-6658. -- Resolution: Fixed Fix Version/s: Metrics_1.0.1 > Issue @Gauge

[jira] [Commented] (GERONIMO-6658) Issue @Gauge Accept: application/json

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704719#comment-16704719 ] ASF GitHub Bot commented on GERONIMO-6658: -- rmannibucau commented on issue #2: GERONIMO-6658

[jira] [Commented] (GERONIMO-6658) Issue @Gauge Accept: application/json

2018-11-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704718#comment-16704718 ] ASF GitHub Bot commented on GERONIMO-6658: -- asfgit closed pull request #2: GERONIMO-6658 -

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - application/json doesn't return correct payload

2018-11-30 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - application/json doesn't return correct payload URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-443199512 Applied, thanks a lot Ivan This is an automated

[GitHub] asfgit closed pull request #2: GERONIMO-6658 - application/json doesn't return correct payload

2018-11-30 Thread GitBox
asfgit closed pull request #2: GERONIMO-6658 - application/json doesn't return correct payload URL: https://github.com/apache/geronimo-metrics/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Re: [jira] [Commented] (GERONIMO-6658) Issue @Gauge Accept: application/json

2018-11-30 Thread Ivan Junckes Filho
Hey Romain, I did all your suggestions. https://github.com/apache/geronimo-metrics/pull/2 Can you review and merge please? On Thu, Nov 29, 2018 at 11:43 AM ASF GitHub Bot (JIRA) wrote: > > [ >

Re: Microprofile OpenAPI

2018-11-30 Thread Ivan Junckes Filho
I think regardless of what the MicroProfile team decides, we need to make it work as the specification says. Then iterate from there. In my opinion this is a big problem that makes us strongly incompatible with the standard. On Fri, Nov 30, 2018 at 3:36 AM Romain Manni-Bucau wrote: > Browser