[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053962119 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053961070 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,65 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053960992 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -80,7 +78,7 @@ public void testGetBytecode() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053025654 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor