[GitHub] [geronimo-batchee] dependabot[bot] closed pull request #16: Bump tomcat-embed-core from 7.0.50 to 7.0.107 in /gui

2023-01-20 Thread GitBox
dependabot[bot] closed pull request #16: Bump tomcat-embed-core from 7.0.50 to 7.0.107 in /gui URL: https://github.com/apache/geronimo-batchee/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geronimo-batchee] dependabot[bot] commented on pull request #16: Bump tomcat-embed-core from 7.0.50 to 7.0.107 in /gui

2023-01-20 Thread GitBox
dependabot[bot] commented on PR #16: URL: https://github.com/apache/geronimo-batchee/pull/16#issuecomment-1398237525 Looks like org.apache.tomcat.embed:tomcat-embed-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [geronimo-batchee] dependabot[bot] opened a new pull request, #17: Bump htmlunit from 2.12 to 2.37.0 in /gui

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #17: URL: https://github.com/apache/geronimo-batchee/pull/17 Bumps [htmlunit](https://github.com/HtmlUnit/htmlunit) from 2.12 to 2.37.0. Release notes Sourced from https://github.com/HtmlUnit/htmlunit/releases";>htmlunit's releases.

[GitHub] [geronimo-batchee] dependabot[bot] opened a new pull request, #16: Bump tomcat-embed-core from 7.0.50 to 7.0.107 in /gui

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/geronimo-batchee/pull/16 Bumps tomcat-embed-core from 7.0.50 to 7.0.107. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.

[GitHub] [geronimo-batchee] jeanouii merged pull request #15: Bump testng from 6.9.9 to 7.7.0

2023-01-19 Thread GitBox
jeanouii merged PR #15: URL: https://github.com/apache/geronimo-batchee/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo

[GitHub] [geronimo-batchee] jeanouii merged pull request #6: Bump commons-io from 2.5 to 2.7 in /tools/cli

2023-01-19 Thread GitBox
jeanouii merged PR #6: URL: https://github.com/apache/geronimo-batchee/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.a

[GitHub] [geronimo-batchee] jeanouii merged pull request #5: Bump spring-boot-starter-web from 2.5.6 to 2.5.12 in /tools/spring-boot-batchee-ui

2023-01-19 Thread GitBox
jeanouii merged PR #5: URL: https://github.com/apache/geronimo-batchee/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.a

[GitHub] [geronimo-batchee] jeanouii merged pull request #8: Bump groovy from 2.1.9 to 2.4.21 in /extensions/groovy

2023-01-19 Thread GitBox
jeanouii merged PR #8: URL: https://github.com/apache/geronimo-batchee/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.a

[GitHub] [geronimo-batchee] dependabot[bot] opened a new pull request, #15: Bump testng from 6.9.9 to 7.7.0

2023-01-19 Thread GitBox
dependabot[bot] opened a new pull request, #15: URL: https://github.com/apache/geronimo-batchee/pull/15 Bumps [testng](https://github.com/cbeust/testng) from 6.9.9 to 7.7.0. Release notes Sourced from https://github.com/cbeust/testng/releases";>testng's releases. TestNG v7.7.

[GitHub] [geronimo-batchee] jeanouii merged pull request #13: Bump jackson-databind from 2.2.3 to 2.12.7.1 in /extensions/jackson

2023-01-19 Thread GitBox
jeanouii merged PR #13: URL: https://github.com/apache/geronimo-batchee/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo

[GitHub] [geronimo-batchee] jeanouii merged pull request #10: Bump camel-core from 2.11.1 to 2.24.0 in /extensions/camel

2023-01-19 Thread GitBox
jeanouii merged PR #10: URL: https://github.com/apache/geronimo-batchee/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo

[GitHub] [geronimo-batchee] jeanouii merged pull request #14: Bump hazelcast from 3.1 to 3.12.13 in /extensions/hazelcast

2023-01-19 Thread GitBox
jeanouii merged PR #14: URL: https://github.com/apache/geronimo-batchee/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo

[GitHub] [geronimo-batchee] jeanouii merged pull request #7: BATCHEE-162 improve reproducible builds

2023-01-19 Thread GitBox
jeanouii merged PR #7: URL: https://github.com/apache/geronimo-batchee/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.a

[GitHub] [geronimo-txmanager] jeanouii merged pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
jeanouii merged PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo

[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1067025406 ## .github/workflows/maven.yml: ## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

[GitHub] [geronimo-txmanager] jeanouii commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
jeanouii commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066964549 ## geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java: ## @@ -24,21 +24,20 @@ import java.util.

[GitHub] [geronimo-txmanager] jeanouii commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
jeanouii commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378710169 Looks good to me. I'll merge it for you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378651316 Ok did the switch to Apache Parent v29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066727262 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT

[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378394073 > As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to merge t

[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066697045 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-SNAPSHOT

[GitHub] [geronimo-txmanager] rmannibucau commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rmannibucau commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378384552 As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to me

[GitHub] [geronimo-txmanager] rmannibucau commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rmannibucau commented on code in PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066690285 ## pom.xml: ## @@ -62,45 +62,45 @@ org.apache.geronimo.components geronimo-transaction -3.1.6-S

[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace

2023-01-11 Thread GitBox
rzo1 commented on PR #8: URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378367735 Genesis Parent: https://issues.apache.org/jira/browse/GERONIMO-6845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [geronimo-txmanager] rzo1 opened a new pull request, #8: Migrate to Jakarta Namespace

2023-01-06 Thread GitBox
rzo1 opened a new pull request, #8: URL: https://github.com/apache/geronimo-txmanager/pull/8 Hi all, don't know, what the future will be, but I did switch from Javax to Jakarta namespace (for EE10) and updated the related spec versions. I don't know, what the plan for Geronimo provi

[GitHub] [geronimo-arthur] dependabot[bot] opened a new pull request, #11: Bump hsqldb from 2.5.1 to 2.7.1 in /integration-test/src/test/resources/integration-tests/openjpa

2023-01-06 Thread GitBox
dependabot[bot] opened a new pull request, #11: URL: https://github.com/apache/geronimo-arthur/pull/11 Bumps hsqldb from 2.5.1 to 2.7.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.hsqldb:hsqldb&package-

[GitHub] [geronimo-arthur] dependabot[bot] closed pull request #9: Bump jackson-databind from 2.13.2.2 to 2.13.4.1 in /arthur-maven-plugin

2023-01-06 Thread GitBox
dependabot[bot] closed pull request #9: Bump jackson-databind from 2.13.2.2 to 2.13.4.1 in /arthur-maven-plugin URL: https://github.com/apache/geronimo-arthur/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geronimo-arthur] dependabot[bot] closed pull request #8: Bump jib-core from 0.17.0 to 0.22.0 in /arthur-maven-plugin

2023-01-06 Thread GitBox
dependabot[bot] closed pull request #8: Bump jib-core from 0.17.0 to 0.22.0 in /arthur-maven-plugin URL: https://github.com/apache/geronimo-arthur/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geronimo-arthur] dependabot[bot] commented on pull request #9: Bump jackson-databind from 2.13.2.2 to 2.13.4.1 in /arthur-maven-plugin

2023-01-06 Thread GitBox
dependabot[bot] commented on PR #9: URL: https://github.com/apache/geronimo-arthur/pull/9#issuecomment-1373489251 Looks like com.fasterxml.jackson.core:jackson-databind is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [geronimo-arthur] dependabot[bot] commented on pull request #8: Bump jib-core from 0.17.0 to 0.22.0 in /arthur-maven-plugin

2023-01-06 Thread GitBox
dependabot[bot] commented on PR #8: URL: https://github.com/apache/geronimo-arthur/pull/8#issuecomment-1373489222 Looks like com.google.cloud.tools:jib-core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [geronimo-arthur] fpapon merged pull request #10: [GERONIMO-6843] Upgrade dependencies to avoid CVE in ossindex:audit

2023-01-06 Thread GitBox
fpapon merged PR #10: URL: https://github.com/apache/geronimo-arthur/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronimo.ap

[GitHub] [geronimo-batchee] dependabot[bot] closed pull request #9: Bump hazelcast from 3.1 to 3.11 in /extensions/hazelcast

2022-12-27 Thread GitBox
dependabot[bot] closed pull request #9: Bump hazelcast from 3.1 to 3.11 in /extensions/hazelcast URL: https://github.com/apache/geronimo-batchee/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [geronimo-batchee] dependabot[bot] commented on pull request #9: Bump hazelcast from 3.1 to 3.11 in /extensions/hazelcast

2022-12-27 Thread GitBox
dependabot[bot] commented on PR #9: URL: https://github.com/apache/geronimo-batchee/pull/9#issuecomment-1365951205 Superseded by #14. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [geronimo-batchee] dependabot[bot] opened a new pull request, #14: Bump hazelcast from 3.1 to 3.12.13 in /extensions/hazelcast

2022-12-27 Thread GitBox
dependabot[bot] opened a new pull request, #14: URL: https://github.com/apache/geronimo-batchee/pull/14 Bumps [hazelcast](https://github.com/hazelcast/hazelcast) from 3.1 to 3.12.13. Release notes Sourced from https://github.com/hazelcast/hazelcast/releases";>hazelcast's releases.

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-24 Thread GitBox
rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1364486933 Thanks a lot for the hard work, really appreciated you did the work to comply to existing codebase, kudo! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [geronimo-xbean] rmannibucau merged pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-24 Thread GitBox
rmannibucau merged PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@geronim

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-23 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056614919 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -54,7 +54,8 @@ public class JarArchiveTest { private JarArchive arc

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056038202 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056038202 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056038202 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056038202 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1056038202 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1055299704 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-22 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1055292190 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-opentracing] dependabot[bot] closed pull request #3: Bump apache-karaf from 4.2.1 to 4.2.3 in /geronimo-opentracing-osgi

2022-12-21 Thread GitBox
dependabot[bot] closed pull request #3: Bump apache-karaf from 4.2.1 to 4.2.3 in /geronimo-opentracing-osgi URL: https://github.com/apache/geronimo-opentracing/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [geronimo-opentracing] dependabot[bot] commented on pull request #3: Bump apache-karaf from 4.2.1 to 4.2.3 in /geronimo-opentracing-osgi

2022-12-21 Thread GitBox
dependabot[bot] commented on PR #3: URL: https://github.com/apache/geronimo-opentracing/pull/3#issuecomment-1361889905 Superseded by #6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [geronimo-opentracing] dependabot[bot] opened a new pull request, #6: Bump apache-karaf from 4.2.1 to 4.3.8 in /geronimo-opentracing-osgi

2022-12-21 Thread GitBox
dependabot[bot] opened a new pull request, #6: URL: https://github.com/apache/geronimo-opentracing/pull/6 Bumps apache-karaf from 4.2.1 to 4.3.8. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.karaf:

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-21 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1054091723 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053962119 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053961070 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,65 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053960992 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -80,7 +78,7 @@ public void testGetBytecode() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-20 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1053025654 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -16,15 +16,10 @@ */ package org.apache.xbean.finder.archive; -impor

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-19 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1052682163 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-18 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051642787 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-18 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051587029 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-18 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051562968 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051486174 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051477609 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051477609 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051477609 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051476696 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051453129 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051448994 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051446076 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051446012 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051445859 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -63,12 +64,12 @@ public void setUp() throws Exception { public void

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051445155 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051444831 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051444664 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -63,12 +64,12 @@ public void setUp() throws Exception { public void

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051443644 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -63,12 +64,12 @@ public void setUp() throws Exception { public void

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051442994 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -63,12 +64,12 @@ public void setUp() throws Exception { public void

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051440953 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -95,14 +96,65 @@ public void testIterator() throws Exception {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051440363 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051439651 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051438054 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-17 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1051356926 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +44,63 @@ public class JarArchive implements Archive, AutoCloseable {

[GitHub] [geronimo] dependabot[bot] opened a new pull request, #22: Bump spring-beans from 2.5.6-SEC02 to 5.2.20.RELEASE

2022-12-15 Thread GitBox
dependabot[bot] opened a new pull request, #22: URL: https://github.com/apache/geronimo/pull/22 Bumps [spring-beans](https://github.com/spring-projects/spring-framework) from 2.5.6-SEC02 to 5.2.20.RELEASE. Release notes Sourced from https://github.com/spring-projects/spring-framewo

[GitHub] [geronimo-gshell] dependabot[bot] opened a new pull request, #7: Bump spring-beans from 2.5.6 to 5.2.20.RELEASE in /gshell-support/gshell-spring

2022-12-15 Thread GitBox
dependabot[bot] opened a new pull request, #7: URL: https://github.com/apache/geronimo-gshell/pull/7 Bumps [spring-beans](https://github.com/spring-projects/spring-framework) from 2.5.6 to 5.2.20.RELEASE. Release notes Sourced from https://github.com/spring-projects/spring-framewor

[GitHub] [geronimo-xbean] dependabot[bot] opened a new pull request, #35: Bump spring-beans from 2.0.5 to 5.2.20.RELEASE in /maven-xbean-plugin

2022-12-15 Thread GitBox
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/geronimo-xbean/pull/35 Bumps [spring-beans](https://github.com/spring-projects/spring-framework) from 2.0.5 to 5.2.20.RELEASE. Release notes Sourced from https://github.com/spring-projects/spring-framewo

[GitHub] [geronimo-xbean] powerbroker commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-12 Thread GitBox
powerbroker commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1346563119 > If it helps, here is a proposal a bit simpler, does not do validation but explicitly only only `file:` and `jar:file:`: https://gist.github.com/rmannibucau/ced8a809672a12a6f026e5

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-12 Thread GitBox
rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1346090560 If it helps, here is a proposal a bit simpler, does not do validation but explicitly only only `file:` and `jar:file:`: https://gist.github.com/rmannibucau/ced8a809672a12a6f026e5cc

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045497969 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045496483 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045314578 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045282542 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception { @

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045282353 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345631321 Open point to maybe discuss (can be on the list): do we want to deprecate `public JarArchive(ClassLoader loader, URL url) {` and promote a `public JarArchive(ClassLoader loader, Fi

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045281610 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception { @

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045281235 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269358 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception { @

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045271076 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception { @

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private f

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

2022-12-11 Thread GitBox
powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269358 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception { @

  1   2   3   4   5   6   >