[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1364486933 Thanks a lot for the hard work, really appreciated you did the work to comply to existing codebase, kudo! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1346090560 If it helps, here is a proposal a bit simpler, does not do validation but explicitly only only `file:` and `jar:file:`: https://gist.github.com/rmannibucau/ced8a809672a12a6f026e5cc

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345631321 Open point to maybe discuss (can be on the list): do we want to deprecate `public JarArchive(ClassLoader loader, URL url) {` and promote a `public JarArchive(ClassLoader loader, Fi

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345503365 This actually hits a java bug where nested '!' are not supported in urls. Can you at least add a boolean toggle in JarArchuve to switch the behavior cause opposite bug exists too