[ 
https://issues.apache.org/jira/browse/GERONIMO-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215028#comment-13215028
 ] 

Russell E Glaue edited comment on GERONIMO-6286 at 2/23/12 8:37 PM:
--------------------------------------------------------------------

geronimo-6286-BaseJava-StartServer-StartClient.patch
Modifies:
- 
framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/BaseJavaCommand.java
- 
framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- 
framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java

Please review this patch.
I thought it best to keep this one simple and require the user to specify the 
full path for the org.apache.geronimo.server.dir if they wish to define it.

                
      was (Author: rglaue):
    geronimo-6286-BaseJava-StartServer-StartClient.patch
Modifies:
- 
framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
- 
framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java

Please review this patch.
I thought it best to keep this one simple and require the user to specify the 
full path for the org.apache.geronimo.server.dir if they wish to define it.

                  
> o.a.g.server.dir should be used instead of o.a.g.home.dir in misc places
> ------------------------------------------------------------------------
>
>                 Key: GERONIMO-6286
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6286
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>    Affects Versions: 3.0-beta-1
>         Environment: Linux x86, Red Hat Enterprise Linux Server release 5.4 
> (Tikanga); Java JDK1.6.0_25
>            Reporter: Russell E Glaue
>              Labels: geronimo
>         Attachments: geronimo-6286-BaseJava-StartServer-StartClient.patch, 
> geronimo-6286-EmbeddedDaemon-CommandUnlockKeystore-DeployUtils.patch
>
>
> There are some code files still using org.apache.geronimo.home.dir when 
> instead they should ideally be using org.apache.geronimo.server.dir .
> - 
> framework/modules/geronimo-system/src/main/java/org/apache/geronimo/system/main/EmbeddedDaemon.java
> - 
> framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/CommandUnlockKeystore.java
> - 
> framework/modules/geronimo-deploy-tool/src/main/java/org/apache/geronimo/deployment/cli/DeployUtils.java
> - 
> framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartServerCommand.java
> - 
> framework/modules/geronimo-shell-base/src/main/java/org/apache/geronimo/shell/geronimo/StartClientCommand.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to