[
https://issues.apache.org/jira/browse/GERONIMO-3720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rick McGuire closed GERONIMO-3720.
----------------------------------
Resolution: Fixed
Assignee: Rick McGuire
Committed revision 608106.
Look good. Thanks for following up on this Sangjin.
> the thread pool should be properly shut down in AHC sample app
> --------------------------------------------------------------
>
> Key: GERONIMO-3720
> URL: https://issues.apache.org/jira/browse/GERONIMO-3720
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: sample apps
> Affects Versions: 1.x
> Reporter: Sangjin Lee
> Assignee: Rick McGuire
> Priority: Minor
> Attachments: 3720.patch
>
>
> There was a recent API change with AsyncHttpClient, and the lifecycle
> management of the thread pool now belongs to the caller (see GERONIMO-3707).
> As a result, the thread pool needs to be shut down properly in the servlet's
> destroy method.
> In addition, the current sample creates a bounded thread pool (using
> Executors.newFixedThreadPool()). If you do a stress test on this servlet,
> this doesn't work well, as it causes an unnecessary performance penalty.
> Mina recommends using an unbounded thread pool, and this thread pool is
> usually very well regulated in practice, so there is no need to use a bounded
> thread pool here. See http://mina.apache.org/configuring-thread-model.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
