[ http://issues.apache.org/jira/browse/DAYTRADER-9?page=comments#action_12423753 ] Matt Hogstrom commented on DAYTRADER-9: ---------------------------------------
Slava, there is an if in the patch + if ( (topGainersData.size() > 0) || (topGainersData.size() > 0)){ I'm not sure why the comparison is duplicated. Did you mean to have another value for the comparison? I expect we only need one of the comparisons but wanted to check. > MarketSummary fix for NPE with less than 106 quotes > --------------------------------------------------- > > Key: DAYTRADER-9 > URL: http://issues.apache.org/jira/browse/DAYTRADER-9 > Project: DayTrader > Issue Type: Improvement > Components: EJB Tier > Affects Versions: 1.1 > Environment: All OS / all platforms > Reporter: Slava > Attachments: DAYTRADER-9.patch > > > This is a fix for the NPE in the MarketSummary.jsp and TradeHome.jsp thrown > when the Daytrader database contains only 100 or less quotes. (see > http://issues.apache.org/jira/browse/GERONIMO-1674) > The current default configuration is 200 users and 400 quotes. As previously > discussed, it takes long time to populate Daytrader database with as many > user/quotes. > This fix solves that problem. No NPE will be thrown if the database is > populated with less than 105 quotes. This will speed up significantly the > functional test with Daytrader. > However, to retrieve market summary data you still need to have more than 106 > quotes in the database. Therefore for performance measurments with Daytrader > should be done using higher number of users/quotes. > Slava -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira