[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Donald Woods (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662994#action_12662994 ] Donald Woods commented on GERONIMO-4507: Is the attached patch for 2.1 or 2.2?

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663174#action_12663174 ] Gang Yin commented on GERONIMO-4507: My patch is going to rename all *.properties to

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663175#action_12663175 ] Gang Yin commented on GERONIMO-4507: I have no idea why all *.properties files are r

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Jack Cai (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663233#action_12663233 ] Jack Cai commented on GERONIMO-4507: I'm not sure whether it's correct to only inclu

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663235#action_12663235 ] Gang Yin commented on GERONIMO-4507: Hi, Jack. I had tested your concern and english

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-12 Thread Jarek Gawor (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663237#action_12663237 ] Jarek Gawor commented on GERONIMO-4507: --- If the code is using standard ResourceBun

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-13 Thread Jack Cai (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663355#action_12663355 ] Jack Cai commented on GERONIMO-4507: I don't quite understand why only the language

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-13 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663357#action_12663357 ] Gang Yin commented on GERONIMO-4507: Updated patch on the basis of Rev734145 > Admi

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-02-09 Thread caiwenjing (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671783#action_12671783 ] caiwenjing commented on GERONIMO-4507: -- I give the priority of my language setting

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-05 Thread Donald Woods (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679211#action_12679211 ] Donald Woods commented on GERONIMO-4507: Is this for both 2.1 and 2.2? > Admin

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-05 Thread Joe Bohn (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679229#action_12679229 ] Joe Bohn commented on GERONIMO-4507: I suspect we need unique patches for trunk and

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-05 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679467#action_12679467 ] Gang Yin commented on GERONIMO-4507: BTW, geronimo-4507 and geronimo-4517 is patch

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-06 Thread Joe Bohn (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679627#action_12679627 ] Joe Bohn commented on GERONIMO-4507: Applied locale-priority_fix2_v22.patch to trunk

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-06 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679828#action_12679828 ] Gang Yin commented on GERONIMO-4507: Thanks Joe, I will provide a patch for 2.1 bran

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-17 Thread Joe Bohn (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682733#action_12682733 ] Joe Bohn commented on GERONIMO-4507: We need a patch for this in the next day or two

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-17 Thread Gang Yin (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682923#action_12682923 ] Gang Yin commented on GERONIMO-4507: As Kan Ogawa hadn't finished porting G-4484(bac

[jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-17 Thread Kan Ogawa (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682934#action_12682934 ] Kan Ogawa commented on GERONIMO-4507: - Gang, To resolve this issue for V2.1, is it

Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-13 Thread Gang Yin
Of course we can use both language and country parts, but now we only provide property files like *.zh.properties rather than *.zh-CN.properties, I'm not sure if locale like zh-CN will match *.zh.properties. I will test it, and If getLanguage() is not necessary I will remove it. On Tue, Jan 13, 20

Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-13 Thread Jack Cai
It will. You can read the javadoc of ResourceBundle to see how it searches the bundles for a given locale. -Jack 2009/1/13 Gang Yin > Of course we can use both language and country parts, but now we only > provide property files like *.zh.properties rather than *.zh-CN.properties, > I'm not su

Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-01-13 Thread Gang Yin
yes, it's redundant code, I will remove it. On Tue, Jan 13, 2009 at 11:30 PM, Jack Cai wrote: > It will. You can read the javadoc of ResourceBundle to see how it searches > the bundles for a given locale. > > -Jack > > > 2009/1/13 Gang Yin > > Of course we can use both language and country part

Re: [jira] Commented: (GERONIMO-4507) Admin console should honor the priority of user agent's language setting

2009-03-17 Thread Gang Yin
Hi Kan Currently for 2.1 branch, everything is all right, the patch you had submitted in this JIRA is enough. 2009/3/18 Kan Ogawa (JIRA) > >[ > https://issues.apache.org/jira/browse/GERONIMO-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=126