Re: About daytrader patches

2009-03-12 Thread Forrest Xia
Having some files missing in the initial patch is my mistake, sorry for that. I will do be careful for patch inspection before submission. Thank you for your patience. Forrest

Re: About daytrader patches

2009-03-12 Thread Donald Woods
Any additional improvements (whether listed below or otherwise) would be greatly appreciated. Keep the patches coming! -Donald Forrest Xia wrote: Noticed that. After sync my work copy with server, I found some jboss configuration files are missing, so I add those missing files via daytrad

Re: About daytrader patches

2009-03-12 Thread Donald Woods
Can you be more specific? You patch included the deletion of 3 files. Was that a mistake in the patch creation? -Donald Forrest Xia wrote: Noticed that. After sync my work copy with server, I found some jboss configuration files are missing, so I add those missing files via daytrader-65 j

Re: About daytrader patches

2009-03-12 Thread Forrest Xia
Noticed that. After sync my work copy with server, I found some jboss configuration files are missing, so I add those missing files via daytrader-65 jira, please help check and commit them. thanks again! Next, I plan to provide some additional patches for these aspects: 1. extend the support data

Re: About daytrader patches

2009-03-12 Thread Donald Woods
Also applied your patch for DAYTRADER-66. -Donald Donald Woods wrote: Done. All three patches have been applied to branches/2.1.3 and trunk. -Donald Forrest_Xia wrote: Hi folks, Is there anyone has time to help look at JIRA daytrader-63, 64, 65? Please help review and commit them if it's

Re: About daytrader patches

2009-03-12 Thread Forrest Xia
Thanks Donald!

Re: About daytrader patches

2009-03-12 Thread Donald Woods
Done. All three patches have been applied to branches/2.1.3 and trunk. -Donald Forrest_Xia wrote: Hi folks, Is there anyone has time to help look at JIRA daytrader-63, 64, 65? Please help review and commit them if it's ok for us. If anything unclear, please comment on them. I will have more

About daytrader patches

2009-03-11 Thread Forrest_Xia
ntext: http://www.nabble.com/About-daytrader-patches-tp22469673s134p22469673.html Sent from the Apache Geronimo - Dev mailing list archive at Nabble.com.