Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-22 Thread Ashish Jain
I will apply the fix to this issue tomorrow to g 2.1 branch. On Thu, Mar 18, 2010 at 7:04 PM, Ashish Jain wrote: > I tried fixing this up by making FileKeystoreInstance serializable however > I hit another issue > > > java.rmi.UnmarshalException: error unmarshalling return; nested exception > is

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-18 Thread Ashish Jain
I tried fixing this up by making FileKeystoreInstance serializable however I hit another issue java.rmi.UnmarshalException: error unmarshalling return; nested exception is: java.io.WriteAbortedException: writing aborted; java.io.NotSerializableE xception: org.apache.geronimo.kernel.basic.P

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-16 Thread Ashish Jain
Thanks Jack and Joe for your choices. I will go ahead and implement the option #1. On Mon, Mar 15, 2010 at 9:17 PM, Jack Cai wrote: > Interesting... Since the problem is really that FileKeystoreInstance is not > seriazable, I don't see why changing the getter return type would help if > the rece

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-15 Thread Jack Cai
Interesting... Since the problem is really that FileKeystoreInstance is not seriazable, I don't see why changing the getter return type would help if the received objects are still instances of FileKeystoreInstance. Anyway, I agree with Joe - Option 1 looks more elegant. -Jack On Mon, Mar 15, 201

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-14 Thread Ashish Jain
The serialization problem is popping up due to the return type associated with getKeystores(). But in the case of getKeystores1() there is no return variable. So it helps in overcoming this problem. On Mon, Mar 15, 2010 at 8:18 AM, Jack Cai wrote: > I still don't quite understand Option 2. So wh

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-14 Thread Jack Cai
I still don't quite understand Option 2. So what would be stored in this new attribute "keystores1"? If it still contains an instance of FileKeystoreInstance, then there is still a serialization problem. -Jack On Sat, Mar 13, 2010 at 5:20 PM, Ashish Jain wrote: > Hi Joe, > > Thanks for your com

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-13 Thread Ashish Jain
Hi Joe, Thanks for your comments. The intent of using option #2 was to make use of getAttribute and also since modifying the KeystoreManager interface will not have any effect on any existing functionalities. However as you pointed out a get method w/o any return types may be misleading. Thanks A

Re: Discussion: Possible fixes for GERONIMO-5180

2010-03-12 Thread Joe Bohn
I don't know much about the details of the problem but it seems to me that you would either make the class serializable (option #1) or exclude it from serialization if it is not necessary. I don't see how this would impact any existing functions. So I guess I would vote for #1. I don't under

Discussion: Possible fixes for GERONIMO-5180

2010-03-12 Thread Ashish Jain
Hi ALL, I have opened up a JIRA GERONIMO-5180 on the unlockKeystore command failure if keystore is created with keytool.exe. I was trying to fix this issue which requires some changes in the class declaration or interface. Following code is being utilized to fix up the issue KeystoreInstance[] key