Re: branches/2.1 freeze notice

2008-02-08 Thread Viet Nguyen
Erik, I thought you were talking about something else. And I like the change, thanks for noticing it. --Viet On Feb 8, 2008 12:41 PM, Kevan Miller <[EMAIL PROTECTED]> wrote: > > On Feb 8, 2008, at 12:14 PM, Erik B. Craig wrote: > > > Kevan, > > > > I have a very small change to make to mconsole-

Re: branches/2.1 freeze notice

2008-02-08 Thread Kevan Miller
On Feb 8, 2008, at 12:14 PM, Erik B. Craig wrote: Kevan, I have a very small change to make to mconsole-war/src/main/java/org/ apache/geronimo/monitoring/console/MonitoringPortlet.java to prevent a potential stack trace if the user clicks the portlet 'edit' button at the top of the portle

Re: branches/2.1 freeze notice

2008-02-08 Thread Erik B. Craig
Viet, It's an error that should've been prevented but wasn't being, it's just some error checking being added. Thanks, Erik B. Craig [EMAIL PROTECTED] On Feb 8, 2008, at 11:18 AM, Viet Nguyen wrote: Erik, I do not think we should prevent this stack trace. I think it's important that th

Re: branches/2.1 freeze notice

2008-02-08 Thread Viet Nguyen
Erik, I do not think we should prevent this stack trace. I think it's important that the user knows what's up. So we should at least write it to a log. Thanks, Viet On Feb 8, 2008 12:14 PM, Erik B. Craig <[EMAIL PROTECTED]> wrote: > Kevan, > > I have a very small change to make to > mconsole-war

Re: branches/2.1 freeze notice

2008-02-08 Thread Erik B. Craig
Kevan, I have a very small change to make to mconsole-war/src/main/java/org/apache/geronimo/monitoring/console/MonitoringPortlet.java to prevent a potential stack trace if the user clicks the portlet 'edit' button at the top of the portlet. Would it be possible to get this in? Thanks, Erik B. Cra

Re: branches/2.1 freeze notice

2008-02-08 Thread Kevan Miller
On Feb 6, 2008, at 10:29 AM, Kevan Miller wrote: All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you feel absolutely *must* be fixed, please check with me. I'll be working on generating a 2.1 release candidate later thi

Re: branches/2.1 freeze notice

2008-02-07 Thread Donald Woods
I just added a jtidy-8.0-20060801 into the local repo, which was the latest SNAPSHOT version that was out on the sf.net repo. -Donald Jarek Gawor wrote: Thanks, you beat me to it! I'll also update branches/2.0. Jarek On Feb 7, 2008 12:15 PM, Donald Woods <[EMAIL PROTECTED]> wrote: I just r

Re: branches/2.1 freeze notice

2008-02-07 Thread Jarek Gawor
Thanks, you beat me to it! I'll also update branches/2.0. Jarek On Feb 7, 2008 12:15 PM, Donald Woods <[EMAIL PROTECTED]> wrote: > I just removed the bottom 3 in the 2.1 branch with Rev619508 based on > the changes you made in trunk. I'll start looking at pulling jtidy into > the local repo next

Re: branches/2.1 freeze notice

2008-02-07 Thread Donald Woods
I just removed the bottom 3 in the 2.1 branch with Rev619508 based on the changes you made in trunk. I'll start looking at pulling jtidy into the local repo next. -Donald Jarek Gawor wrote: I just performed a quick scan for direct snapshot dependencies in branches/2.1, here's the list (exclu

Re: branches/2.1 freeze notice

2008-02-07 Thread Gianny Damour
On 07/02/2008, at 2:54 AM, Joe Bohn wrote: Kevan Miller wrote: All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you feel absolutely *must* be fixed, please check with me. I'll be working on generating a 2.1 release candidate

Re: branches/2.1 freeze notice

2008-02-06 Thread Jarek Gawor
I just performed a quick scan for direct snapshot dependencies in branches/2.1, here's the list (excluding jacc spec and ejbcontainer-tests): ./buildsupport/testsuite-maven-plugin/pom.xml: jtidy 8.0-SNAPSHOT ./plugins/monitoring/agent-jmx/pom.xml: xbean-naming 3.4-SNAPSHOT ./testsuite/pom.xml: mav

Re: branches/2.1 freeze notice

2008-02-06 Thread Kevan Miller
On Feb 6, 2008, at 1:26 PM, Donald Woods wrote: Should we fix the following SNAPSHOT depends, which break offline builds in 2.1 or wait for 2.1.1? I can make the changes this afternoon... We won't be releasing with direct SNAPSHOT dependencies. These will all be updated as part of the re

Re: branches/2.1 freeze notice

2008-02-06 Thread Kevan Miller
On Feb 6, 2008, at 10:54 AM, Joe Bohn wrote: Kevan Miller wrote: All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you feel absolutely *must* be fixed, please check with me. I'll be working on generating a 2.1 release candid

Re: branches/2.1 freeze notice

2008-02-06 Thread Donald Woods
Should we fix the following SNAPSHOT depends, which break offline builds in 2.1 or wait for 2.1.1? I can make the changes this afternoon... -Donald Kevan Miller wrote: All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you f

Re: branches/2.1 freeze notice

2008-02-06 Thread Joe Bohn
Kevan Miller wrote: All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you feel absolutely *must* be fixed, please check with me. I'll be working on generating a 2.1 release candidate later this afternoon/eveniing. --kevan

branches/2.1 freeze notice

2008-02-06 Thread Kevan Miller
All, In preparation for our 2.1 release, please hold off on any commits to branches/2.1. If you have something that you feel absolutely *must* be fixed, please check with me. I'll be working on generating a 2.1 release candidate later this afternoon/eveniing. --kevan