Re: svn commit: r1129174 - in /geronimo/server/trunk: framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ plugins/client/geronimo-client-builder/src/main/java/org/apach

On Jun 1, 2011, at 5:22 PM, David Jencks wrote: But first please explain why you think this change is correct. It looks wrong to me, and I think the test was correct. Maybe i don't understand what the test is doing, but I don't think libfolder/ is in the manifest classpath being tested

Re: svn commit: r1129174 - in /geronimo/server/trunk: framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ plugins/client/geronimo-client-builder/src/main/java/org/apach

This commit broke the build. See http://ci.apache.org/builders/geronimo-server-trunk/builds/41 Can you fix the test errors? --kevan On May 30, 2011, at 9:50 AM, genspr...@apache.org wrote: Author: genspring Date: Mon May 30 13:50:57 2011 New Revision: 1129174 URL:

Re: svn commit: r1129174 - in /geronimo/server/trunk: framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ plugins/client/geronimo-client-builder/src/main/java/org/apach

But first please explain why you think this change is correct. It looks wrong to me, and I think the test was correct. Maybe i don't understand what the test is doing, but I don't think libfolder/ is in the manifest classpath being tested but it shows up in the results. Why should it?

Re: svn commit: r1129174 - in /geronimo/server/trunk: framework/modules/geronimo-deployment/src/main/java/org/apache/geronimo/deployment/ plugins/client/geronimo-client-builder/src/main/java/org/apach

Could you please open a jira for the ClassPathUtils changes and give examples of the incorrect behavior and correct behavior? Have you eliminated the MFCP_STRICT flag? thanks david jencks On May 30, 2011, at 6:50 AM, genspr...@apache.org wrote: Author: genspring Date: Mon May 30 13:50:57