Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-17 Thread Jason Dillon
Sure, I'm gonna try and get Ivy working. --jason On Oct 17, 2008, at 1:32 PM, Guillaume Nodet wrote: Looks good, I can work on fixing that if you want. On Fri, Oct 17, 2008 at 8:23 AM, Jason Dillon <[EMAIL PROTECTED]> wrote: Yes, I suppose the PluginParser can set this, and thus avoid ne

Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-16 Thread Guillaume Nodet
Looks good, I can work on fixing that if you want. On Fri, Oct 17, 2008 at 8:23 AM, Jason Dillon <[EMAIL PROTECTED]> wrote: > Yes, I suppose the PluginParser can set this, and thus avoid needing to make > it part of the Command intf. > > --jason > > > On Oct 16, 2008, at 2:33 PM, Guillaume Nodet w

Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-16 Thread Jason Dillon
Yes, I suppose the PluginParser can set this, and thus avoid needing to make it part of the Command intf. --jason On Oct 16, 2008, at 2:33 PM, Guillaume Nodet wrote: Yeah, I was supposing so. However, it seems more natural, as the only place where the location is set is when registering the

Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-16 Thread Guillaume Nodet
Actually, using a cast makes things very difficult to use in OSGi, as when using spring-dm in OSGi, it creates proxies for the commands, so the cast does not work and we end up with exceptions everywhere, as the location is a mandatory part of the command. On Thu, Oct 16, 2008 at 9:33 AM, Guillaum

Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-16 Thread Guillaume Nodet
Yeah, I was supposing so. However, it seems more natural, as the only place where the location is set is when registering the command in the registry. Maybe another way would be to say that the location has to be set on the command in some way before registering it: the registry would retrieve the

Re: svn commit: r704975 - in /geronimo/gshell/trunk: gshell-api/src/main/java/org/apache/geronimo/gshell/command/Command.java gshell-wisdom/gshell-wisdom-core/src/main/java/org/apache/geronimo/gshell/

2008-10-16 Thread Jason Dillon
I didn't really want to expose setLocation in Command, hence the reason why it was coded like that. --jason On Oct 16, 2008, at 1:04 AM, [EMAIL PROTECTED] wrote: Author: gnodet Date: Wed Oct 15 11:04:24 2008 New Revision: 704975 URL: http://svn.apache.org/viewvc?rev=704975&view=rev Log: Re