Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-27 Thread Dain Sundstrom
On Sep 27, 2004, at 5:13 AM, Geir Magnusson Jr wrote: Style question... why have the param Object planFile, rather than overload with real types? lazyness... it was originally File planFile, but then I got to the point where I need to pass an xmlbeans object though, so I just made it Object. -d

Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-27 Thread Geir Magnusson Jr
Style question... why have the param Object planFile, rather than overload with real types? On Sep 26, 2004, at 1:27 PM, Dain Sundstrom wrote: On Sep 26, 2004, at 3:55 AM, David Jencks wrote: This might be moving in a good direction overall, but one aspect totally sucks, namely that in the Modul

Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-26 Thread Dain Sundstrom
On Sep 26, 2004, at 10:41 AM, David Jencks wrote: On Sep 26, 2004, at 10:27 AM, Dain Sundstrom wrote: On Sep 26, 2004, at 3:55 AM, David Jencks wrote: This might be moving in a good direction overall, but one aspect totally sucks, namely that in the ModuleBuilder interface in the Module create

Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-26 Thread David Jencks
On Sep 26, 2004, at 10:27 AM, Dain Sundstrom wrote: On Sep 26, 2004, at 3:55 AM, David Jencks wrote: This might be moving in a good direction overall, but one aspect totally sucks, namely that in the ModuleBuilder interface in the Module createModule(String name, Object planFile, JarFile modu

Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-26 Thread Dain Sundstrom
On Sep 26, 2004, at 3:55 AM, David Jencks wrote: This might be moving in a good direction overall, but one aspect totally sucks, namely that in the ModuleBuilder interface in the Module createModule(String name, Object planFile, JarFile moduleFile, URL specDDUrl, String targetPath) throws De

Re: svn commit: rev 47239 - in geronimo/trunk/modules: client-builder/src/java/org/apache/geronimo/client/builder connector/src/java/org/apache/geronimo/connector/deployment connector/src/test/org/apache/geronimo/connector/deployment deployment/src/java/org/apache/geronimo/deployment deployment/src/java/org/apache/geronimo/deployment/plugin deployment/src/java/org/apache/geronimo/deployment/service deployment/src/java/org/apache/geronimo/deployment/util j2ee/src/java/org/apache/geronimo/j2ee j2ee/src/java/org/apache/geronimo/j2ee/deployment j2ee/src/test/org/apache/geronimo/j2ee/deployment jetty/src/java/org/apache/geronimo/jetty/deployment

2004-09-26 Thread David Jencks
This might be moving in a good direction overall, but one aspect totally sucks, namely that in the ModuleBuilder interface in the Module createModule(String name, Object planFile, JarFile moduleFile, URL specDDUrl, String targetPath) throws DeploymentException; method the planFile can be