My thought is that after reviewing a lot of patches, I honestly don't
care about the imports... If your IDE can do something sensible with
them, that's great. But they have no effect on the code or add any
extra effort to the code reviews.
On Fri, Jun 29, 2012 at 10:34 PM, Avery Ching wrote:
>
It's not silly at all. I suggest that we add some checkstyle rules for
enforcing our convention as well.
http://checkstyle.sourceforge.net/config_imports.html
I like AvoidStarImport, RedundantImport, UnusedImports, and (most
related to this question) ImportOrder.
Any thoughts?
Avery
On 6/
It's not silly at all. I suggest that we add some checkstyle rules for
enforcing our convention as well.
http://checkstyle.sourceforge.net/config_imports.html
I like AvoidStarImport, RedundantImport, UnusedImports, and (most
related to this question) ImportOrder.
Any thoughts?
Avery
On 6/
[
https://issues.apache.org/jira/browse/GIRAPH-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Reisman updated GIRAPH-225:
---
Attachment: GIRAPH-225-1.patch
> Guava version in POM.XML is really old. Updated to version 12.0
Eli Reisman created GIRAPH-225:
--
Summary: Guava version in POM.XML is really old. Updated to
version 12.0
Key: GIRAPH-225
URL: https://issues.apache.org/jira/browse/GIRAPH-225
Project: Giraph
I
[
https://issues.apache.org/jira/browse/GIRAPH-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404192#comment-13404192
]
Eugene Koontz commented on GIRAPH-212:
--
Will set "patch available" once I figure out
[
https://issues.apache.org/jira/browse/GIRAPH-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eugene Koontz updated GIRAPH-212:
-
Attachment: GIRAPH-212.patch
This patch allows Giraph to run on a secure Hadoop 1.0 install. The
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: (was: GIRAPH-221.patch)
> Make iteration over edges more explicit
> -
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: GIRAPH-221-1.patch
Small nit: getEdgesIterator() instead of getEdgeIterator()
[
https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan resolved GIRAPH-205.
Resolution: Fixed
> Move Giraph jar to root level of tar.gz
> -
[
https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated GIRAPH-205:
---
Assignee: Roman Shaposhnik (was: Eli Reisman)
> Move Giraph jar to root level of tar.gz
> --
[
https://issues.apache.org/jira/browse/GIRAPH-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated GIRAPH-223:
---
Summary: Need to put Giraph jar on classpath, post-GIRAPH-205. (was:
GIRAPH-205 needs to put new gir
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404113#comment-13404113
]
Eugene Koontz commented on GIRAPH-211:
--
I should mention that Zookeeper supports both
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404104#comment-13404104
]
Eugene Koontz commented on GIRAPH-211:
--
I'm happy to help Maja or take over this JIRA
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404034#comment-13404034
]
Jakob Homan commented on GIRAPH-211:
This JIRA is going to require a pretty good under
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404033#comment-13404033
]
Andrew Purtell commented on GIRAPH-211:
---
bq. My first understanding was that we want
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404015#comment-13404015
]
Maja Kabiljo commented on GIRAPH-211:
-
I'm not sure what am I supposed to do here. My
[
https://issues.apache.org/jira/browse/GIRAPH-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403997#comment-13403997
]
Alessandro Presta commented on GIRAPH-200:
--
Hi Eli, I'm trying to run the tests i
[
https://issues.apache.org/jira/browse/GIRAPH-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403978#comment-13403978
]
Alessandro Presta commented on GIRAPH-224:
--
I did this in BspServiceWorker, let m
[
https://issues.apache.org/jira/browse/GIRAPH-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-224:
-
Attachment: GIRAPH-224.patch
> Server-side combiner
>
>
>
Alessandro Presta created GIRAPH-224:
Summary: Server-side combiner
Key: GIRAPH-224
URL: https://issues.apache.org/jira/browse/GIRAPH-224
Project: Giraph
Issue Type: Improvement
Hi all,
Kind of a silly concern, but nevertheless:
IntelliJ IDEA does a great job at optimizing imports for you. While doing so,
it also insists in reorganizing them following some logic.
Since it's not nice to have a patch dirtied by imports reordering every time a
different person touches a c
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: GIRAPH-221.patch
Here's a first iteration (pun intended).
>
[
https://issues.apache.org/jira/browse/GIRAPH-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403818#comment-13403818
]
Alessandro Presta commented on GIRAPH-141:
--
Eli, we agree on the definition of mu
[
https://issues.apache.org/jira/browse/GIRAPH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maja Kabiljo updated GIRAPH-81:
---
Attachment: GIRAPH-81-1.patch
> Create annotations on provided algorithms for cli
> --
[
https://issues.apache.org/jira/browse/GIRAPH-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403801#comment-13403801
]
Maja Kabiljo commented on GIRAPH-81:
Could you please try running it now? I managed to
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403774#comment-13403774
]
Jake Mannix commented on GIRAPH-221:
@Eli, ok, I can see the fact that it's hard to fi
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403773#comment-13403773
]
Jake Mannix commented on GIRAPH-221:
given the target I vertexId of the out edge, you
28 matches
Mail list logo